From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ting Xu <ting.xu@intel.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, beilei.xing@intel.com,
bernard.iremonger@intel.com, stable@dpdk.org,
Andrew Rybchenko <arybchenko@solarflare.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang
Date: Mon, 11 May 2020 17:29:09 +0100 [thread overview]
Message-ID: <238b76ff-262a-effd-811e-21b58c9b259d@intel.com> (raw)
In-Reply-To: <20200511102504.23936-1-ting.xu@intel.com>
On 5/11/2020 11:25 AM, Ting Xu wrote:
> When set DCB in testpmd by clang, there is a segmentation fault.
> It is because the local variable rss_conf in get_eth_dcb_conf()
> is not cleared, so that the pointer member variable rss_key has
> a random address, which leads to an error in the following
> processing. This patch initialized the local variable rss_conf
> to avoid random address.
This is nothing really FreeBSD or clang issue, although it may be reproduced
that environment, this is a pointer with random value issue. We may drop FreeBSD
and clang reference to not create confusion.
>
> Fixes: b57b66a97ebf ("app/testpmd: support mbuf dynamic flag")
This commit looks unrelated, if not can you please explain why above commit
causing the issue?
> Cc: stable@dpdk.org
>
> Signed-off-by: Ting Xu <ting.xu@intel.com>
> ---
> app/test-pmd/testpmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 99bacddbf..1276476ca 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3408,6 +3408,7 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,
> int32_t rc;
> struct rte_eth_rss_conf rss_conf;
>
> + memset(&rss_conf, 0, sizeof(struct rte_eth_rss_conf));
The variable is used in the 'else' leg, memset can be moved there, but more
importantly should this be done in the 'rte_eth_dev_rss_hash_conf_get()' API.
@Andrew, @Thomas,
What do you think 'rte_eth_dev_rss_hash_conf_get()' memset the 'rss_conf' param
before passing it to the PMD? To prevent issues like above in user application.
next prev parent reply other threads:[~2020-05-11 16:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 10:25 Ting Xu
2020-05-11 5:12 ` Xing, Beilei
2020-05-11 7:50 ` Huang, ZhiminX
2020-05-11 16:29 ` Ferruh Yigit [this message]
2020-05-12 2:17 ` Xu, Ting
2020-05-12 11:42 ` Iremonger, Bernard
2020-05-12 10:13 ` [dpdk-dev] [PATCH v2] app/testpmd: fix DCB set failure Ting Xu
2020-05-18 17:06 ` Ferruh Yigit
2020-05-13 9:50 ` [dpdk-dev] [PATCH v3] " Ting Xu
2020-05-13 10:07 ` [dpdk-dev] [PATCH v4] " Ting Xu
2020-05-13 8:54 ` Iremonger, Bernard
2020-05-13 12:58 ` Thomas Monjalon
2020-05-13 17:16 ` [dpdk-dev] [PATCH v5] ethdev: " Ting Xu
2020-05-13 13:28 ` Ferruh Yigit
2020-05-18 16:24 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-05-13 15:54 ` [dpdk-dev] " Iremonger, Bernard
2020-05-18 13:32 ` Andrew Rybchenko
2020-05-18 14:57 ` Matan Azrad
2020-05-18 16:21 ` Ferruh Yigit
2020-05-18 16:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=238b76ff-262a-effd-811e-21b58c9b259d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=ting.xu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).