From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 648861D7; Tue, 13 Nov 2018 17:58:07 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 039032208D; Tue, 13 Nov 2018 11:58:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 13 Nov 2018 11:58:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=wRY+m84bXsOAI4kKElT4rPD17wxnjD2ts3o36gB/2Qo=; b=InxHSZ497qwv B9YGuHwa8a14kI+XnoNOpJ5hANk91Fx1EM6t3gpCrpwJ/2kAhpMtGZlK3uLeDjh0 uqsrHNrnwfkMAMDvlAenxFBCXUuwim2IMjcucrV3fUgxFbJ4NOr95LQKIgXWaEhI c20t9tEdGYmhDlRaPCIQxDScrAJl8p8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=wRY+m84bXsOAI4kKElT4rPD17wxnjD2ts3o36gB/2 Qo=; b=pxgI5+nQpV+yprEqWzDWTjkMhmsALURWMkdqBM94pQ1vKm+pPbVZXKKut AWfI3qFf1a5r9x9VFNxQV/1x5/tLgTLVGQiFMQD7muB42tLbKHHkInpqNu0DNDKQ Dc5a+fLqt5o4lzdYiM+OUtYh4dmoPXUQ4Sr/Gwj5Ymfd7ii76E9LYWch81fmXJMu WBOlV4c1TvL4bYxBsdnznhV3J/VXnlbSjHGURcymWZ44H17dg5x7dF2mbDndhcpM Z0Phfqitz2n8dSq2k9RIC10wHZ5SFqLO0Qf3xCQ8nqqzajTrc7nGl5s6UqAg2+Bo 9Ibf1quQ5YCy8zi8EAOyUjH0vO9+w== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 01667102DE; Tue, 13 Nov 2018 11:58:05 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Bruce Richardson , vipin.varghese@intel.com, stable@dpdk.org Date: Tue, 13 Nov 2018 17:57:59 +0100 Message-ID: <2394199.rkv9bdJ101@xps> In-Reply-To: <7096e585fd36399cea92dd32fe1f19b051697bec.1542124270.git.anatoly.burakov@intel.com> References: <88cced4f601c44c6203b9adb09abacdce0b3a260.1542122595.git.anatoly.burakov@intel.com> <7096e585fd36399cea92dd32fe1f19b051697bec.1542124270.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 16:58:07 -0000 13/11/2018 16:54, Anatoly Burakov: > When creating process data structures, EAL will create many files > in EAL runtime directory. Because we allow multiple secondary > processes to run, each secondary process gets their own unique > file. With many secondary processes running and exiting on the > system, runtime directory will, over time, create enormous amounts > of sockets, fbarray files and other stuff that just sits there > unused because the process that allocated it has died a long time > ago. This may lead to exhaustion of disk (or RAM) space in the > runtime directory. > > Fix this by removing every unlocked file at initialization that > matches either socket or fbarray naming convention. We cannot be > sure of any other files, so we'll leave them alone. Also, remove > similar code from mp socket code. > > We do it at the end of init, rather than at the beginning, because > secondary process will use primary process' data structures even > if the primary itself has died, and we don't want to remove those > before we lock them. > > Bugzilla ID: 106 > > Cc: stable@dpdk.org > > Reported-by: Vipin Varghese > > Signed-off-by: Anatoly Burakov I feel it is too big and too late for 18.11. Can we move it to 19.02?