From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 305903237 for ; Sun, 7 Feb 2016 22:27:19 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id g62so110696330wme.0 for ; Sun, 07 Feb 2016 13:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Rke7lHfGHnaxTrMWLG5sTjn7f2VQpix7Su22+JXl4B4=; b=L+/T0ZwiBvt9jgbW346adlkSsmoYfhRWbqzYdNXgAistD+xKfTk799d9kQkNM/hWt+ DjWsvwkdjxm/UvfdiF6iV/+JJ1kZ5jwboqQKRnn3OnJVHddNYCETYb3/NJ4lLBwbLHm9 XFS+S8sB5qVU70iQyjy4/5vq6aXmPvH8teLRf307uGfEVYud/loxJ6MfCuchBSIlxedF u/h0rKm7jBAamGdnZPOUziZfbMgwZLMH4hb54ENmmTy4bZw9Fwm/qMGJF3G6H2qU1DPw e9fmC2ymfnLm3LV8KPJrk7jjiFa1EuIBnVaDF1FZZaCBNBSypyoOx9xJwMkHxW5KCYaR Af8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Rke7lHfGHnaxTrMWLG5sTjn7f2VQpix7Su22+JXl4B4=; b=SyhSE+ACP3anXi8mgkLUFQO24BAV4138DFLfN3i9yYMDyOQ1tkGhMuITRMlO5D9zXz FA3b1VBppJ24owIV7oX4zSk/WBXB7wgA2qkYarkqZe434L11mUUWbH2Mjxl5g7Td6oKj TSOFNac1aqIO+tKJWuelrEeg2wBw9UrV93acRsJPPPUtMrV1nJA+l+TvArB0JMRacNrz aldbqekReq521JT8s+zwy3O7tQ0UIFGgD6G5Pk05uO0yTSEAhEZoDleefIyyQ2+F+TJ7 z8o9POLoQUkr/FyEZyJuRb6jJNKXazu9p+T/eHnrGYEIMYEbMqJzAPPPy5pWpzmOmdvQ w8hQ== X-Gm-Message-State: AG10YOQaFZ8jEXxPzEL72te9WDd2+tSR5bvCgybvtKZ1WsKFu4QTQV0bJJO97xNtW+PJkpZZ X-Received: by 10.194.79.194 with SMTP id l2mr27440355wjx.160.1454880438956; Sun, 07 Feb 2016 13:27:18 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id e194sm9529293wma.19.2016.02.07.13.27.17 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 07 Feb 2016 13:27:18 -0800 (PST) From: Thomas Monjalon To: Santosh Shukla , huawei.xie@intel.com, yuanhan.liu@linux.intel.com Date: Sun, 07 Feb 2016 22:25:57 +0100 Message-ID: <2395124.Wzh8l6ZlGf@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1454853068-14621-3-git-send-email-sshukla@mvista.com> References: <1454853068-14621-1-git-send-email-sshukla@mvista.com> <1454853068-14621-3-git-send-email-sshukla@mvista.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 2/4] virtio: Introduce config RTE_VIRTIO_INC_VECTOR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Feb 2016 21:27:19 -0000 2016-02-07 19:21, Santosh Shukla: > - virtio_recv_pkts_vec and other virtio vector friend apis are written for > sse/avx instructions. For arm64 in particular, virtio vector implementation > does not exist(todo). > > So virtio pmd driver wont build for targets like i686, arm64. By making > RTE_VIRTIO_INC_VECTOR=n, Driver can build for non-sse/avx targets and will work > in non-vectored virtio mode. > > Disabling RTE_VIRTIO_INC_VECTOR config for : > > - i686 arch as i686 target config says: > config/defconfig_i686-native-linuxapp-gcc says "Vectorized PMD is not > supported on 32-bit". > > - armv7/v8 arch. Yes it can be useful to disable vector optimizations, but it should done at runtime, not a compilation option. I know it is already wrongly configured at compilation for other drivers, we should fix them. Here, you want to avoid SSE/AVX code on ARM. So we should just add the appropriate ifdefs. Adding a compilation option does not prevent from enabling it on ARM or old x86 which do not support these instructions. Please virtio maintainers, we need to fix this code. Thanks