From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84214A00C2; Mon, 23 May 2022 16:42:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D95B4014F; Mon, 23 May 2022 16:42:08 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 9F5AE40141 for ; Mon, 23 May 2022 16:42:06 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 333F75C0160; Mon, 23 May 2022 10:42:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 23 May 2022 10:42:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653316926; x= 1653403326; bh=E5Vs+22waUTcKz2hvo105e9uVRyeQdNqymEN7LsU6U0=; b=q fsqFmvc4KtEpZrKUcXmzK2MUd+Wolpd0IfHQc5Hfsz5WtyBO11rfucs87SvZA+4L 0ilEFeqCogaQCV9bS4CN7qwD4jT1NwufPCdiVHexr1BHZWEvS2vOV93rjOyuN02m tbiUER+1T+0lzKpBIoQj8fd9P2jmX1aOGUneZWvFA1DFv128XxoXEX6rW+SUbPlo rvOfCFx1sdeY79/SxR4I+O3ETwix8WcVMRn3CtdXkf6mQWKk4BkcyosAjLOPs2vy RC+crwk1QgEMSYFhGkLlMYNZUGtw2cQFNfSCYdpMbW6PLiJrJJ1Fpyr95V771DON qdW4XIxtkz8fA97/T9Gog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653316926; x= 1653403326; bh=E5Vs+22waUTcKz2hvo105e9uVRyeQdNqymEN7LsU6U0=; b=P S0EFQ2zKMItGIn96lR704wai7xns9XkvpDY/LEztQEnKS1Wadg7E9LcpuPn0JDu+ 8QPVWXtpy2aaIISIJg56HvTM3AcUtR3VaZDpodwGGqT1ToMTsU6cOSViHG3KYZD0 Hg8C7UNF+Y5N419i8vC11ET1/NcJkrVPRvFgxsoXSP/K2X2oteDorm5FJwVMFIZD 2t5FQ2vcZWQcvLb9HVW0/opDvHCj862vnqut1yEPSoNFb9grh+v/8RnSNS2hnB6z FMgcPOHuj4zDJDD+qp3kN1zzWV5spl4NgJmCJ6szBEJ3st509hQkwRpUiR8VmAE7 ZpWdx5bMEiVO1IAGUw2sg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjedugdeglecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 May 2022 10:42:04 -0400 (EDT) From: Thomas Monjalon To: Subendu Santra Cc: Reshma Pattan , Stephen Hemminger , Hemant Agrawal , dev@dpdk.org Subject: Re: [PATCH] app/procinfo: show all non-owned ports Date: Mon, 23 May 2022 16:41:57 +0200 Message-ID: <23962511.kmuVQn2iE0@thomas> In-Reply-To: References: <20220510132118.22688-1-subendu@arista.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/05/2022 12:53, Subendu Santra: > Hi Reshma, Thomas, > > What do you think about this patch? It looks to be a fix, right? Please add a sentence about the previous behaviour, explaining what is fixed. Ideally you should show the commit doing the mistake with the syntax "Fixes:" as in other commits of this tree. Thanks > On Tue, May 10, 2022 at 6:52 PM Subendu Santra wrote: > > > > Show all non-owned ports when no port mask is specified > > > > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned > > ports") > > Cc: stephen@networkplumber.org > > > > Signed-off-by: Subendu Santra > > --- > > app/proc-info/main.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c > > index 56070a3317..2be24b584e 100644 > > --- a/app/proc-info/main.c > > +++ b/app/proc-info/main.c > > @@ -1504,10 +1504,10 @@ main(int argc, char **argv) > > if (nb_ports == 0) > > rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n"); > > > > - /* If no port mask was specified, then show non-owned ports */ > > + /* If no port mask was specified, then show all non-owned ports */ > > if (enabled_port_mask == 0) { > > RTE_ETH_FOREACH_DEV(i) > > - enabled_port_mask = 1ul << i; > > + enabled_port_mask |= (1ul << i); > > } > > > > for (i = 0; i < RTE_MAX_ETHPORTS; i++) { > > -- > > 2.28.0 > > >