* [dpdk-dev] [PATCH] examples/l3fwd-power: fix assignment errors
@ 2021-04-21 3:53 Min Hu (Connor)
2021-05-12 19:34 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Min Hu (Connor) @ 2021-04-21 3:53 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, david.hunt
From: HongBo Zheng <zhenghongbo3@huawei.com>
Fix assignment errors of ep_hgh_edpi in function parse_ep_config.
Fixes: a137d012a0dd ("examples/l3fwd-power: support traffic pattern aware control")
Cc: stable@dpdk.org
Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
examples/l3fwd-power/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 0af8810..f8dfed1 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1748,7 +1748,7 @@ parse_ep_config(const char *q_arg)
int hgh_edpi;
ep_med_edpi = EMPTY_POLL_MED_THRESHOLD;
- ep_hgh_edpi = EMPTY_POLL_MED_THRESHOLD;
+ ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD;
strlcpy(s, p, sizeof(s));
@@ -1771,7 +1771,7 @@ parse_ep_config(const char *q_arg)
if (med_edpi > 0)
ep_med_edpi = med_edpi;
- if (med_edpi > 0)
+ if (hgh_edpi > 0)
ep_hgh_edpi = hgh_edpi;
} else {
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix assignment errors
2021-04-21 3:53 [dpdk-dev] [PATCH] examples/l3fwd-power: fix assignment errors Min Hu (Connor)
@ 2021-05-12 19:34 ` Thomas Monjalon
2021-05-13 9:09 ` Pattan, Reshma
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2021-05-12 19:34 UTC (permalink / raw)
To: david.hunt, reshma.pattan, anatoly.burakov
Cc: dev, ferruh.yigit, Min Hu (Connor)
Ping for review please.
21/04/2021 05:53, Min Hu (Connor):
> From: HongBo Zheng <zhenghongbo3@huawei.com>
>
> Fix assignment errors of ep_hgh_edpi in function parse_ep_config.
>
> Fixes: a137d012a0dd ("examples/l3fwd-power: support traffic pattern aware control")
> Cc: stable@dpdk.org
>
> Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> examples/l3fwd-power/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index 0af8810..f8dfed1 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -1748,7 +1748,7 @@ parse_ep_config(const char *q_arg)
> int hgh_edpi;
>
> ep_med_edpi = EMPTY_POLL_MED_THRESHOLD;
> - ep_hgh_edpi = EMPTY_POLL_MED_THRESHOLD;
> + ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD;
>
> strlcpy(s, p, sizeof(s));
>
> @@ -1771,7 +1771,7 @@ parse_ep_config(const char *q_arg)
> if (med_edpi > 0)
> ep_med_edpi = med_edpi;
>
> - if (med_edpi > 0)
> + if (hgh_edpi > 0)
> ep_hgh_edpi = hgh_edpi;
>
> } else {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix assignment errors
2021-05-12 19:34 ` Thomas Monjalon
@ 2021-05-13 9:09 ` Pattan, Reshma
2021-05-13 9:47 ` David Hunt
0 siblings, 1 reply; 5+ messages in thread
From: Pattan, Reshma @ 2021-05-13 9:09 UTC (permalink / raw)
To: Thomas Monjalon, Hunt, David, Burakov, Anatoly
Cc: dev, Yigit, Ferruh, Min Hu (Connor)
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Ping for review please.
>
<snip>
> 21/04/2021 05:53, Min Hu (Connor):
> > From: HongBo Zheng <zhenghongbo3@huawei.com>
> >
> > + ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD;
<snip>
> >
> > + if (hgh_edpi > 0)
> > ep_hgh_edpi = hgh_edpi;
> >
Changes looks good to me.
Reviewed-by: Reshma Pattan <reshma.pattan@gmail.com>
Thanks,
Reshma
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix assignment errors
2021-05-13 9:09 ` Pattan, Reshma
@ 2021-05-13 9:47 ` David Hunt
2021-05-19 6:43 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: David Hunt @ 2021-05-13 9:47 UTC (permalink / raw)
To: Pattan, Reshma, Thomas Monjalon, Burakov, Anatoly
Cc: dev, Yigit, Ferruh, Min Hu (Connor)
On 13/5/2021 10:09 AM, Pattan, Reshma wrote:
>
>> -----Original Message-----
>> From: Thomas Monjalon <thomas@monjalon.net>
>> Ping for review please.
>>
> <snip>
>
>> 21/04/2021 05:53, Min Hu (Connor):
>>> From: HongBo Zheng <zhenghongbo3@huawei.com>
>>>
>>> + ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD;
> <snip>
>>> + if (hgh_edpi > 0)
>>> ep_hgh_edpi = hgh_edpi;
>>>
> Changes looks good to me.
>
> Reviewed-by: Reshma Pattan <reshma.pattan@gmail.com>
>
>
> Thanks,
> Reshma
+1
Acked-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix assignment errors
2021-05-13 9:47 ` David Hunt
@ 2021-05-19 6:43 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-05-19 6:43 UTC (permalink / raw)
To: Min Hu (Connor)
Cc: Pattan, Reshma, Burakov, Anatoly, dev, dev, Yigit, Ferruh, David Hunt
13/05/2021 11:47, David Hunt:
> On 13/5/2021 10:09 AM, Pattan, Reshma wrote:
> >> 21/04/2021 05:53, Min Hu (Connor):
> >>> From: HongBo Zheng <zhenghongbo3@huawei.com>
> >>>
> >>> + ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD;
> > <snip>
> >>> + if (hgh_edpi > 0)
> >>> ep_hgh_edpi = hgh_edpi;
> >>>
> > Changes looks good to me.
> >
> > Reviewed-by: Reshma Pattan <reshma.pattan@gmail.com>
> >
> >
> > Thanks,
> > Reshma
>
>
> +1
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-19 6:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 3:53 [dpdk-dev] [PATCH] examples/l3fwd-power: fix assignment errors Min Hu (Connor)
2021-05-12 19:34 ` Thomas Monjalon
2021-05-13 9:09 ` Pattan, Reshma
2021-05-13 9:47 ` David Hunt
2021-05-19 6:43 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).