From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by dpdk.org (Postfix) with ESMTP id 162021B477 for ; Fri, 1 Feb 2019 00:26:43 +0100 (CET) Received: by mail-qk1-f196.google.com with SMTP id y16so2975821qki.7 for ; Thu, 31 Jan 2019 15:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZUGuL/DJKzRxwiTbfQku61uALx9UBhKwwk1LeM6NMlc=; b=V9DPkMQ+z7TVxT9oHTqZLQYkP6bLdah3OUFv0+LIDQBPU6IgKzj4QjvcT1JCoC6caA rOmGq89+HTdv/Nq8C68mDotvcbopYSLwIPYGlmuN8sBFzF2YFi8UyTCa9CeaC4F0KupE U8Wx3l4uNdxnTET7JibISq3OmLtZvl/7idcUDUX5w6VJI3qtdR4G+v0u1h4n5LVamDfu 7JB7uHLBdqexqgpLWhVkIV2nltg5WEKTBfUWbn8+TGmG2ZU4rMjxZk+6E3mcBgnvFG0k Kdgp6ZztxejFoL1FQLsQJUHH9SSJ3rU47m6Gg5HYwOgO/gSYZr3uh41U1G0BAYn6qc8r j04A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZUGuL/DJKzRxwiTbfQku61uALx9UBhKwwk1LeM6NMlc=; b=KxE3fuFnhpw5LOFqF0nMCFSXSu7h8wMmUehiOiu7vNEKSVmcCx9mACFAbkA4M4TKzJ La5eNMvVm2paI/wt0TotxDte/ia5NRJJxRRqnSwAUhIM9D3D19TOTYN1IAgjuOgulMNb Y+7qO1LAvswtxDFw0bJAYEBrUeNBYkYbiizuftWNxKjhXz9hzkS+ZpyYkXpN75Itaend IK730IKhR50mRCPboCUZ8wNJ2QolchSvi0Efx+6b4x90NscTG2nywXUwdU0vlzvL7W9c BuuM5yBeoRUjv4ZOxOGQtPgYeAYwwZ5Jzzq1cXA3Ak727+oulUyMEf4V4gJY6WEJGuIn 0s1A== X-Gm-Message-State: AHQUAuaGFQgN4SjpeHHotr4W8D7LAKXszEEkkG6JmfGsCTQOskXjdJbV 2ZiOqpgt/2SZbgVSaZuBuCI= X-Google-Smtp-Source: AHgI3Ibf/22g+R3lW+i7g1wiPn39JU2Y1VU/j2OTsG+1t2KvlWEMza3ODON0fBinhPlB4UOeVSHjIA== X-Received: by 2002:a37:9b41:: with SMTP id d62mr5923556qke.215.1548977202474; Thu, 31 Jan 2019 15:26:42 -0800 (PST) Received: from [192.168.1.10] (pool-96-255-82-34.washdc.fios.verizon.net. [96.255.82.34]) by smtp.gmail.com with ESMTPSA id y32sm5113484qth.3.2019.01.31.15.26.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 15:26:41 -0800 (PST) To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, Luca Boccassi References: <20190131021858.5832-1-3chas3@gmail.com> <20190131093203.GD122080@bricha3-MOBL.ger.corp.intel.com> From: Chas Williams <3chas3@gmail.com> Message-ID: <23a3a256-0347-f6ed-c2b8-d923d7a6749d@gmail.com> Date: Thu, 31 Jan 2019 18:26:41 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190131093203.GD122080@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] build: add option to override max ethports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 23:26:43 -0000 On 1/31/19 4:32 AM, Bruce Richardson wrote: > On Wed, Jan 30, 2019 at 09:18:58PM -0500, Chas Williams wrote: >> Allow users and packagers to override the default RTE_MAX_ETHPORTS. >> This adds a new meson option, max_ethports which defaults to the >> current value. >> >> Signed-off-by: Chas Williams <3chas3@gmail.com> > > Agree with the idea. Just one small comment below re alphabetical order. > > Otherwise: > Acked-by: Bruce Richardson > ... > > We are trying to keep the options in alphabetical order, so this setting > should be just before "max_lcores" rather than at the end. If you look at the last few lines in this file: option('use_hpet', type: 'boolean', value: false, description: 'use HPET timer in EAL') option('tests', type: 'boolean', value: true, description: 'build unit tests') I couldn't detect any ordering so I just appended. I can submit a v2. > Interestingly, I see that since 0.45 there is now the option of an > "integer" option type. We should probably switch to use that once we bump > our minimum meson version. [Luca, perhaps another change for your set?] > Ref: http://mesonbuild.com/Build-options.html#integers I just followed along with what everyone else was doing.