From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 245A5388F for ; Wed, 7 Dec 2016 19:29:53 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 07 Dec 2016 10:29:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,315,1477983600"; d="scan'208";a="909789291" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 07 Dec 2016 10:29:51 -0800 To: Tom Crugnale , jingjing.wu@intel.com, helin.zhang@intel.com References: <1481055381-14243-1-git-send-email-tcrugnale@sandvine.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <23ab0bd6-be41-893c-87e6-1ed43897dd2b@intel.com> Date: Wed, 7 Dec 2016 18:29:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481055381-14243-1-git-send-email-tcrugnale@sandvine.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] net/i40evf: fix reporting of imissed packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 18:29:54 -0000 On 12/6/2016 8:16 PM, Tom Crugnale wrote: > Missed packets on RX were erroneously being assigned to the ierrors > struct member. Change it to be assigned to imissed. > > Fixes: 4861cde4 ("i40e: new poll mode driver") > > Signed-off-by: Tom Crugnale > --- > v3: > * Fixed coding style issues > v2: > * Fixed line breaks in original patch submission > --- > > drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index aa306d6..90876c8 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -952,7 +952,7 @@ struct rte_i40evf_xstats_name_off { > } > > static int > -i40evf_get_statics(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > +i40evf_get_stats(struct rte_eth_dev *dev, struct rte_eth_stats *stats) I aware this is simple modification, but if you can, can you please make this separate patch? Stable trees may not interested in internal function name changes but may want to get stats counter fix. > { > int ret; > struct i40e_eth_stats *pstats = NULL; > @@ -965,7 +965,7 @@ struct rte_i40evf_xstats_name_off { > pstats->rx_broadcast; > stats->opackets = pstats->tx_broadcast + pstats->tx_multicast + > pstats->tx_unicast; > - stats->ierrors = pstats->rx_discards; > + stats->imissed = pstats->rx_discards; so won't VF driver report any rx_error? > stats->oerrors = pstats->tx_errors + pstats->tx_discards; This line is not part of the patch, but what do you think about this one, should oerrors contain tx_discards values? > stats->ibytes = pstats->rx_bytes; > stats->obytes = pstats->tx_bytes; > @@ -2277,8 +2277,8 @@ static int i40evf_dev_xstats_get(struct rte_eth_dev *dev, > static void > i40evf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > { > - if (i40evf_get_statics(dev, stats)) > - PMD_DRV_LOG(ERR, "Get statics failed"); > + if (i40evf_get_stats(dev, stats)) > + PMD_DRV_LOG(ERR, "Get stats failed"); > } > > static void >