From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 546FC43F76;
Fri, 3 May 2024 15:58:28 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9DC21402EF;
Fri, 3 May 2024 15:58:19 +0200 (CEST)
Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15])
by mails.dpdk.org (Postfix) with ESMTP id C1911402ED;
Fri, 3 May 2024 15:58:17 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1714744698; x=1746280698;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=3+1q1rJsnAnHbPex4c0izxH0zCks4iPMXqmPPj95sEI=;
b=VbQHi4Byy9H6uPRo5fXup/WFDxpyzHxUmswwPwAcwCzuy/Wc9w2o8Wqc
ZbDv/5pJyt8z9oO2NIxsaedn7At+uM23IEGIHfZOQbIMW26l4KbxTo5KP
6vEcond4ctkkENN6u/FczM7tEdGi5Ifx+zPI19mWyq20wS2pYvUIUo8qJ
jGc2mcyvQ4MekSDCUkWHBec59fAacvDncnkL+9nXXpY1BG26TcVb95E77
rTAG5cpNYkKsvvJyPGNDGFmvgZy2newspIcdOrOr40ECfFjHhh4dqmSIC
akyioQjHD3MmRV7hyL0w6R4GZPmQslHpZGCl+HpmHFQzWhXhquRRLAYx/ g==;
X-CSE-ConnectionGUID: Pvq/vOOUS6eyXccp7/Zi1Q==
X-CSE-MsgGUID: Gn9aXlL4T9aqoIvbhPAP+g==
X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="10714893"
X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="10714893"
Received: from fmviesa002.fm.intel.com ([10.60.135.142])
by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
03 May 2024 06:58:17 -0700
X-CSE-ConnectionGUID: BKUgmWXURcuXiAPG7Nk9hg==
X-CSE-MsgGUID: 0MiI+8AbRz6t7UxgDxFBCQ==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="50641900"
Received: from silpixa00401119.ir.intel.com ([10.55.129.167])
by fmviesa002.fm.intel.com with ESMTP; 03 May 2024 06:58:15 -0700
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org,
Wei Dai <wei.dai@intel.com>
Cc: Piotr Skajewski <piotrx.skajewski@intel.com>,
bruce.richardson@intel.com, vladimir.medvedkin@intel.com,
stable@dpdk.org, Tyl@dpdk.org, RadoslawX <radoslawx.tyl@intel.com>,
Mrozowicz@dpdk.org, SlawomirX <slawomirx.mrozowicz@intel.com>,
Michael@dpdk.org, Alice <alice.michael@intel.com>
Subject: [PATCH v2 02/27] net/ixgbe/base: fix wrong 5G link speed reported on
VF
Date: Fri, 3 May 2024 14:57:33 +0100
Message-ID: <23b6e4e066a4004f450e369c1887d06589a843dc.1714744628.git.anatoly.burakov@intel.com>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <cover.1714744628.git.anatoly.burakov@intel.com>
References: <cover.1713964707.git.anatoly.burakov@intel.com>
<cover.1714744628.git.anatoly.burakov@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
From: Piotr Skajewski <piotrx.skajewski@intel.com>
When 5000 Base-T was set on PF the VF reported 100 Base-T.
This patch change ixgbe_check_mac_link_vf function
where was incorrect conditional which points to PF mac types,
now it is pointing correctly to VF mac types.
Fixes: 12e20906905c ("net/ixgbe/base: include new speeds in VFLINK interpretation")
Cc: stable@dpdk.org
Signed-off-by: Piotr Skajewski <piotrx.skajewski@intel.com>
Reviewed-by: Tyl, RadoslawX <radoslawx.tyl@intel.com>
Reviewed-by: Mrozowicz, SlawomirX <slawomirx.mrozowicz@intel.com>
Reviewed-by: Michael, Alice <alice.michael@intel.com>
---
drivers/net/ixgbe/base/ixgbe_vf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_vf.c b/drivers/net/ixgbe/base/ixgbe_vf.c
index 5e3ae1b519..11dbbe2a86 100644
--- a/drivers/net/ixgbe/base/ixgbe_vf.c
+++ b/drivers/net/ixgbe/base/ixgbe_vf.c
@@ -585,7 +585,7 @@ s32 ixgbe_check_mac_link_vf(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
switch (links_reg & IXGBE_LINKS_SPEED_82599) {
case IXGBE_LINKS_SPEED_10G_82599:
*speed = IXGBE_LINK_SPEED_10GB_FULL;
- if (hw->mac.type >= ixgbe_mac_X550) {
+ if (hw->mac.type >= ixgbe_mac_X550_vf) {
if (links_reg & IXGBE_LINKS_SPEED_NON_STD)
*speed = IXGBE_LINK_SPEED_2_5GB_FULL;
}
@@ -595,7 +595,7 @@ s32 ixgbe_check_mac_link_vf(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
break;
case IXGBE_LINKS_SPEED_100_82599:
*speed = IXGBE_LINK_SPEED_100_FULL;
- if (hw->mac.type == ixgbe_mac_X550) {
+ if (hw->mac.type == ixgbe_mac_X550_vf) {
if (links_reg & IXGBE_LINKS_SPEED_NON_STD)
*speed = IXGBE_LINK_SPEED_5GB_FULL;
}
@@ -603,7 +603,7 @@ s32 ixgbe_check_mac_link_vf(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
case IXGBE_LINKS_SPEED_10_X550EM_A:
*speed = IXGBE_LINK_SPEED_UNKNOWN;
/* Since Reserved in older MAC's */
- if (hw->mac.type >= ixgbe_mac_X550)
+ if (hw->mac.type >= ixgbe_mac_X550_vf)
*speed = IXGBE_LINK_SPEED_10_FULL;
break;
default:
--
2.43.0