From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A482D426D0;
	Fri,  6 Oct 2023 14:18:28 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 355CA40695;
	Fri,  6 Oct 2023 14:18:28 +0200 (CEST)
Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])
 by mails.dpdk.org (Postfix) with ESMTP id E66534014F
 for <dev@dpdk.org>; Fri,  6 Oct 2023 14:18:26 +0200 (CEST)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
 by mail.lysator.liu.se (Postfix) with ESMTP id A35A4207EA
 for <dev@dpdk.org>; Fri,  6 Oct 2023 14:18:26 +0200 (CEST)
Received: by mail.lysator.liu.se (Postfix, from userid 1004)
 id 97C8F20B80; Fri,  6 Oct 2023 14:18:26 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 hermod.lysator.liu.se
X-Spam-Level: 
X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED,AWL
 autolearn=disabled version=3.4.6
X-Spam-Score: -1.5
Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se
 [62.63.215.114])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.lysator.liu.se (Postfix) with ESMTPSA id B6AFB2037F;
 Fri,  6 Oct 2023 14:18:25 +0200 (CEST)
Message-ID: <23c66954-b560-4cf0-bc50-bab4248b2f8b@lysator.liu.se>
Date: Fri, 6 Oct 2023 14:18:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] random: clarify PRNG MT safety guarantees
Content-Language: en-US
To: David Marchand <david.marchand@redhat.com>,
 =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
 =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>
References: <20231004105449.367667-1-mattias.ronnblom@ericsson.com>
 <CAJFAV8zaahzFjB+u1TkKQPadJLRMnyVQ_cF0w09-RKbaCrxZnQ@mail.gmail.com>
From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <hofors@lysator.liu.se>
In-Reply-To: <CAJFAV8zaahzFjB+u1TkKQPadJLRMnyVQ_cF0w09-RKbaCrxZnQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: ClamAV using ClamSMTP
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2023-10-06 11:13, David Marchand wrote:
> On Wed, Oct 4, 2023 at 1:00 PM Mattias Rönnblom
> <mattias.ronnblom@ericsson.com> wrote:
>>
>> Clarify MT safety guarantees for unregistered non-EAL threads calling
>> PRNG functions in rte_random.h.
>>
>> Clarify that rte_srand() is not MT safe in regards to calls to
>> rte_rand_max() and rte_drand().
>>
>> Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
>> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> 
> Should it be backported along 3a4e21301c7a ("random: initialize state
> for unregistered non-EAL threads") ?
> 
> 

I don't think that's worth the trouble, but if someone has a different 
opinion, I also don't mind if it is.