From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85D20A04E1; Tue, 22 Sep 2020 11:06:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C2CB1DCC2; Tue, 22 Sep 2020 11:06:26 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5F1321DBE5; Tue, 22 Sep 2020 11:06:25 +0200 (CEST) IronPort-SDR: Hngyvs88brruqsx1ScTz1yoCv0VURqmmaTJWhQRO0Z4aGe9NyEIhzxOr9B/q954PNzrZeR6u9K CrQwcZCGq9Eg== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="161490517" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="161490517" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 02:06:24 -0700 IronPort-SDR: 5lYZ8Zdicn7EoWNyKrG0vBhQIrT2kmpDnmFhrefIzFMpo3JG3j2PrKhAJixgKQqRPlLkvtQekO RZ0m87GPCyIw== X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="454421129" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.201]) ([10.213.227.201]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 02:06:23 -0700 To: Junyu Jiang , dev@dpdk.org Cc: Jeff Guo , Beilei Xing , stable@dpdk.org References: <20200910015426.3140-1-junyux.jiang@intel.com> <20200922073713.28938-1-junyux.jiang@intel.com> From: Ferruh Yigit Message-ID: <23d7baeb-fadb-4d4e-1ede-ea0c241fbecc@intel.com> Date: Tue, 22 Sep 2020 10:06:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200922073713.28938-1-junyux.jiang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect byte counters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/2020 8:37 AM, Junyu Jiang wrote: > This patch fixed the issue that rx/tx bytes statistics counters > overflowed on 48 bit limitation by enlarging the limitation. > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Cc: stable@dpdk.org > > Signed-off-by: Junyu Jiang > --- > v4: put reading stats and extending in same function. > v3: create a function to hide the extension inside it. > v2: modify the error code > --- > --- > doc/guides/nics/i40e.rst | 7 ++++ > drivers/net/i40e/i40e_ethdev.c | 66 +++++++++++++++++++++------------- > drivers/net/i40e/i40e_ethdev.h | 9 +++++ > 3 files changed, 57 insertions(+), 25 deletions(-) > > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst > index b7430f6c4..4baa58be6 100644 > --- a/doc/guides/nics/i40e.rst > +++ b/doc/guides/nics/i40e.rst > @@ -830,3 +830,10 @@ Tx bytes affected by the link status change > > For firmware versions prior to 6.01 for X710 series and 3.33 for X722 series, the tx_bytes statistics data is affected by > the link down event. Each time the link status changes to down, the tx_bytes decreases 110 bytes. > + > +RX/TX statistics may be incorrect when register overflowed > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +The rx_bytes/tx_bytes statistics register is 48 bit length. Although this limitation is enlarged to 64 bit length > +on the software side, but there is no way to detect if the overflow occurred more than once. So rx_bytes/tx_bytes > +statistics data is correct when statistics are updated at least once between two overflows. It can be better to move this block next to other know issue related to the stats (Incorrect Rx statistics when packet is oversize), apart from that: Reviewed-by: Ferruh Yigit