From: "Di, ChenxuX" <chenxux.di@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask
Date: Thu, 5 Nov 2020 08:40:23 +0000 [thread overview]
Message-ID: <23d814a8330e46739b014107457f8e8a@intel.com> (raw)
In-Reply-To: <0655e6d1fbbc4b6883ede31c832c7766@intel.com>
Hi, jia
> -----Original Message-----
> From: Di, ChenxuX
> Sent: Wednesday, November 4, 2020 5:49 PM
> To: Guo, Jia <jia.guo@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Subject: RE: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask
>
> Hi, Jia
>
> > -----Original Message-----
> > From: Guo, Jia <jia.guo@intel.com>
> > Sent: Wednesday, November 4, 2020 5:41 PM
> > To: Di, ChenxuX <chenxux.di@intel.com>; dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Wang, Haiyue
> > <haiyue.wang@intel.com>; Di, ChenxuX <chenxux.di@intel.com>;
> > stable@dpdk.org
> > Subject: RE: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask
> >
> > Hi, chenxu
> >
> > > -----Original Message-----
> > > From: Chenxu Di <chenxux.di@intel.com>
> > > Sent: Wednesday, November 4, 2020 4:30 PM
> > > To: dev@dpdk.org
> > > Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia
> > > <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Di,
> > > ChenxuX <chenxux.di@intel.com>; stable@dpdk.org
> > > Subject: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask
> > >
> > > The register of FDIR flex mask should not be set during flow validate.
> > > It should be set when flow create.
> > >
> > > Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for
> > > FDIR")
> >
> > Seems that you move the place of flexible payload parsing from flow
> > validate to create, you delete something but miss some useless
> > parameter deleting, such as " off_arr/len_arr" etc in this [PATCH 1/2]
> > or [PATCH 2/3]. Please double check if anything related remove and if
> > you want you could merge into 1 remove patch if it could be.
> >
>
> Got it, I will double check it.
>
I have double checked the code and I think the other code and parameter in parse function are useful and necessary.
The array off_arr and len_arr is used to store the info of RAW if there are two or more RAW in pattern.
And I will merge into one patch in next version.
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Chenxu Di <chenxux.di@intel.com>
> > > ---
> > > drivers/net/i40e/i40e_ethdev.h | 1 +
> > > drivers/net/i40e/i40e_fdir.c | 94 ++++++++++++++++++++++++++++++++
> > > drivers/net/i40e/i40e_flow.c | 97 +---------------------------------
> > > 3 files changed, 97 insertions(+), 95 deletions(-)
> > >
> >
> > <...>
next prev parent reply other threads:[~2020-11-05 8:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 8:29 [dpdk-dev] [PATCH 0/2] net/i40e: fix incorrect FDIR flex configuration Chenxu Di
2020-11-04 8:29 ` [dpdk-dev] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask Chenxu Di
2020-11-04 9:40 ` Guo, Jia
2020-11-04 9:49 ` Di, ChenxuX
2020-11-05 8:40 ` Di, ChenxuX [this message]
2020-11-04 8:29 ` [dpdk-dev] [PATCH 2/2] net/i40e: fix incorrect FDIR flex pit Chenxu Di
2020-11-04 9:18 ` Guo, Jia
2020-11-06 6:47 ` [dpdk-dev] [PATCH v2] net/i40e: fix incorrect FDIR flex configuration Chenxu Di
2020-11-09 3:23 ` Zhou, JunX W
2020-11-10 5:42 ` [dpdk-dev] [PATCH v3] " Chenxu Di
2020-11-10 6:54 ` Guo, Jia
2020-11-10 7:08 ` [dpdk-dev] [PATCH v4] " Chenxu Di
2020-11-10 8:27 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23d814a8330e46739b014107457f8e8a@intel.com \
--to=chenxux.di@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).