From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 140F5A04B1; Thu, 5 Nov 2020 09:40:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E5EFB5AB7; Thu, 5 Nov 2020 09:40:42 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D0D145958 for ; Thu, 5 Nov 2020 09:40:40 +0100 (CET) IronPort-SDR: khH429cHj9Dk/nso9xi95Iqy/quRfjo6LljAqFak6NxipvfwClpQVnIh0nm/Dc7fIyd5re49WL 5ew/DTsl+9Qw== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="149201722" X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="149201722" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 00:40:26 -0800 IronPort-SDR: SFZbrxKGf23STL7cep53ZqYWM+dgG2lKucmLd3RFej3JbiyKIWFaKRmumlkyPGZKYxhg7/Tppz 5C93+o9bou4A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="527888699" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 05 Nov 2020 00:40:26 -0800 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Nov 2020 00:40:25 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Nov 2020 16:40:23 +0800 Received: from shsmsx605.ccr.corp.intel.com ([10.109.6.215]) by SHSMSX605.ccr.corp.intel.com ([10.109.6.215]) with mapi id 15.01.1713.004; Thu, 5 Nov 2020 16:40:23 +0800 From: "Di, ChenxuX" To: "Guo, Jia" , "dev@dpdk.org" CC: "Xing, Beilei" , "Wang, Haiyue" Thread-Topic: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask Thread-Index: AQHWsoa+o2P8WHzWc0y4uZL+VTUg9Km3MeqAgACIV7CAAXLkUA== Date: Thu, 5 Nov 2020 08:40:23 +0000 Message-ID: <23d814a8330e46739b014107457f8e8a@intel.com> References: <20201104082959.63800-1-chenxux.di@intel.com> <20201104082959.63800-2-chenxux.di@intel.com> <0655e6d1fbbc4b6883ede31c832c7766@intel.com> In-Reply-To: <0655e6d1fbbc4b6883ede31c832c7766@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, jia > -----Original Message----- > From: Di, ChenxuX > Sent: Wednesday, November 4, 2020 5:49 PM > To: Guo, Jia ; dev@dpdk.org > Cc: Xing, Beilei ; Wang, Haiyue > > Subject: RE: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask >=20 > Hi, Jia >=20 > > -----Original Message----- > > From: Guo, Jia > > Sent: Wednesday, November 4, 2020 5:41 PM > > To: Di, ChenxuX ; dev@dpdk.org > > Cc: Xing, Beilei ; Wang, Haiyue > > ; Di, ChenxuX ; > > stable@dpdk.org > > Subject: RE: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask > > > > Hi, chenxu > > > > > -----Original Message----- > > > From: Chenxu Di > > > Sent: Wednesday, November 4, 2020 4:30 PM > > > To: dev@dpdk.org > > > Cc: Xing, Beilei ; Guo, Jia > > > ; Wang, Haiyue ; Di, > > > ChenxuX ; stable@dpdk.org > > > Subject: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask > > > > > > The register of FDIR flex mask should not be set during flow validate= . > > > It should be set when flow create. > > > > > > Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for > > > FDIR") > > > > Seems that you move the place of flexible payload parsing from flow > > validate to create, you delete something but miss some useless > > parameter deleting, such as " off_arr/len_arr" etc in this [PATCH 1/2] > > or [PATCH 2/3]. Please double check if anything related remove and if > > you want you could merge into 1 remove patch if it could be. > > >=20 > Got it, I will double check it. >=20 I have double checked the code and I think the other code and parameter in = parse function are useful and necessary. The array off_arr and len_arr is used to store the info of RAW if there ar= e two or more RAW in pattern. And I will merge into one patch in next version. > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Chenxu Di > > > --- > > > drivers/net/i40e/i40e_ethdev.h | 1 + > > > drivers/net/i40e/i40e_fdir.c | 94 ++++++++++++++++++++++++++++++++ > > > drivers/net/i40e/i40e_flow.c | 97 +-------------------------------= -- > > > 3 files changed, 97 insertions(+), 95 deletions(-) > > > > > > > <...>