From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo04.seg.att.com (nbfkord-smmo04.seg.att.com [209.65.160.86]) by dpdk.org (Postfix) with ESMTP id 6B6462BAC for ; Thu, 24 Nov 2016 16:06:23 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo04.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id fe107385.2ac1bd83b940.226271.00-2416.234198.nbfkord-smmo04.seg.att.com (envelope-from ); Thu, 24 Nov 2016 15:06:23 +0000 (UTC) X-MXL-Hash: 583701ef4e165961-2915be87f6bfb20cdd18c947093ac8965101b7be Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo04.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id 9e107385.0.226057.00-2392.233987.nbfkord-smmo04.seg.att.com (envelope-from ); Thu, 24 Nov 2016 15:06:18 +0000 (UTC) X-MXL-Hash: 583701ea74a06e2c-e1e45670478af07d8c2505cb0fe08a8cd40cb8cb Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 24 Nov 2016 15:05:26 +0000 To: Ferruh Yigit , References: <1479740470-6723-1-git-send-email-arybchenko@solarflare.com> <1479740470-6723-32-git-send-email-arybchenko@solarflare.com> <8d244f7f-59e1-bbe8-9df4-45bff3e3e5cc@intel.com> From: Andrew Rybchenko Message-ID: <23d8b2f3-b13b-5220-244d-45f2ade42396@solarflare.com> Date: Thu, 24 Nov 2016 18:05:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <8d244f7f-59e1-bbe8-9df4-45bff3e3e5cc@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22718.003 X-TM-AS-Result: No--9.618500-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=e9YAPPd/ c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=N659UExz7-8A:10 a=L24OOQBejmoA:10 ] X-AnalysisOut: [a=zRKbQ67AAAAA:8 a=e7p_El43ZMeImylYOAkA:9 a=pILNOxqGKmIA:1] X-AnalysisOut: [0 a=PA03WX8tBzeizutn5_OT:22] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Subject: Re: [dpdk-dev] [PATCH 31/56] net/sfc: implement dummy callback to get device information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 15:06:23 -0000 On 11/23/2016 06:26 PM, Ferruh Yigit wrote: > On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: >> Just a stub to be filled in when corresponding functionality is >> implemented. > What about merging this stub with real implementation? > Or perhaps replace with code that adds dummy .dev_configure? Thanks, I like the second idea. Will do in v2. >> Reviewed-by: Andy Moreton >> Signed-off-by: Andrew Rybchenko >> --- >> drivers/net/sfc/efx/sfc_ethdev.c | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/sfc/efx/sfc_ethdev.c b/drivers/net/sfc/efx/sfc_ethdev.c >> index ff20a13..0deff07 100644 >> --- a/drivers/net/sfc/efx/sfc_ethdev.c >> +++ b/drivers/net/sfc/efx/sfc_ethdev.c >> @@ -37,9 +37,16 @@ >> #include "sfc_kvargs.h" >> >> >> +static void >> +sfc_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) >> +{ >> + struct sfc_adapter *sa = dev->data->dev_private; >> + >> + sfc_log_init(sa, "entry"); >> +} >> + >> static const struct eth_dev_ops sfc_eth_dev_ops = { >> - /* Just dummy init to avoid build-time warning */ >> - .dev_configure = NULL, >> + .dev_infos_get = sfc_dev_infos_get, >> }; >> >> static int >>