From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 855004554D; Tue, 2 Jul 2024 19:26:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74D9B402AD; Tue, 2 Jul 2024 19:26:13 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2064.outbound.protection.outlook.com [40.107.21.64]) by mails.dpdk.org (Postfix) with ESMTP id 527DE40260 for ; Tue, 2 Jul 2024 19:26:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cV9qaSCHBHuyhWbd49jcU9IqioEdEiFe8BZG4rbICRNVwvSnBUaOTzpQZHs1E9E4WMWI7VB/tPakxXg/ETqDmywQ7r2irNz1OBzrzxKsXs3cQN4gno4Hnjs0SRJObJv4BysnSRifDFyYe26zE7voZHgYGNlpSmvJJsU/VMhp2wExi02rQ6Ew5iv+5BS9UNOJHPTxoNna3rUFDbHO1ondkYnN8lVKa6QVP7cP/B415CoPfYxwayCiDKq7UXTGRqUHaxXI8OHHxO0/jeNCCbynMvZOR44Z4ACn37a0Ge0PcmWIN4aaF5KIMutrXEwm4kxcLyIAncjWMSkFJ+aIV+haqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MTkZ/ziA+xtEeGKR1MWIhlozUYyLGt1xZN+UvKohJh0=; b=nAS/Ft+DqU2VZSOWeaSTA8L0Xqz8UQi2Ajp5jNJTls9ZbuoEZt5f9DIvNuQeAJNtU86p9ULsf1eyhfz4vc4ogiNzplQIR4SabnuVtHwBzLd8jpi+MuSRHvcNLOzvrutLeRCgEXXdze+Znlz+A7TFHXRw5G8Q2BCYSlwbNpqRlYS4h4cV3KMfChqHAYffYxBZvazroSrH5LuOxTuafHmcNT0DpJU8+HBrV3mAXIvowoePjsa9dEybpc0dc0gmyATHrGxNNopNpoWVr148P+2Z6DsAGaSvHXGtBdH/5T2iwrilvA2OhAB+Sz6bI7BORgYT0fHpPB6C5aJWVhYyoD0+Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MTkZ/ziA+xtEeGKR1MWIhlozUYyLGt1xZN+UvKohJh0=; b=BLGPF3ADQMN+e5YVcFjj3AyuSoJtQUsbynI4FebF3Jgc1h8QaHiIGzK0MnYfl/7gUQfuG+96gDSAn3cynbc0UIY3hTgRKwvTs1pyXCq8aIQRXXh4KmMMjdFY8FvF+M/nnEhfxfeic+ZXbHUH+6SKJ87885StwKpGmGggcrnR7Ro= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by VI1PR04MB7069.eurprd04.prod.outlook.com (2603:10a6:800:127::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.23; Tue, 2 Jul 2024 17:26:09 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%4]) with mapi id 15.20.7719.028; Tue, 2 Jul 2024 17:26:09 +0000 Message-ID: <23ea33f9-2e88-4be7-cd4b-b29cc264c7b2@oss.nxp.com> Date: Tue, 2 Jul 2024 22:56:03 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 2/2] drivers: replace printf with fprintf for debug functions Content-Language: en-US To: Stephen Hemminger , Hemant Agrawal Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com References: <20230215102905.22767-1-hemant.agrawal@nxp.com> <20240702104013.3813272-1-hemant.agrawal@nxp.com> <20240702104013.3813272-2-hemant.agrawal@nxp.com> <20240702081112.530a5f11@hermes.local> From: Hemant Agrawal In-Reply-To: <20240702081112.530a5f11@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG3P274CA0014.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::26) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|VI1PR04MB7069:EE_ X-MS-Office365-Filtering-Correlation-Id: 1171ca48-7a79-4d37-1613-08dc9abc0fc6 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dEJxRDVTTXRmWW1qMC9MdTdRT29yS3lLOTRaWXB0bVlJb1ByR2Zzbmk2TVlT?= =?utf-8?B?cW5uWkpDdUJvZHB5R1pYclJuM212bkUvaFpYc2ZWN25LNEh3NlR2ZXc4V09E?= =?utf-8?B?Wk5FMmRuTDZqTUQ3SnprK3YxcUkwcVROM2dwY0xOUTl3REZKUjJwemFVZ0FL?= =?utf-8?B?KzVtc2FIVHhxa1hLS2lsOWJpSVpoQ1BwRUU3U01wbjl5V2JqVHl0WWwzYkpt?= =?utf-8?B?TW1YQko1NnJsSHJaNS9OajQwUFgzeStkZk9YMVVnbDBjL3B3YXlhNTRPUkEw?= =?utf-8?B?K3ZmWE1RaU9oT1VVdksxeGh6Z1lNSktaSlJwdEFSSVpTdTRsNi84UlJUWlJV?= =?utf-8?B?ZjZIMm1xY01hNG5oYUpnVXloZzNxYWY0elQ1aHl6NU1maXhlMUtoRElDdHYr?= =?utf-8?B?QjRyK2cycDJjSFlZVGYxblRmTllINUNhWHhsUXdIaWxKZS8wMXRHeGF1RWJU?= =?utf-8?B?NCs4aHMrTjM2R3FlbEN4a055SFBucTV5clRPRHJPbXZRQ3h1dVdJb0FqWHV1?= =?utf-8?B?aFdBUmorWC9RSzI2WGZ4OHFxZDVjak1jWk9HRzVrUnlCNEpRcTYycjd2eUZJ?= =?utf-8?B?QUZ0dDQ3b2FKTWpnOUdMd2xSbEo2c0hzZDByalJqbFdISHpIRkJzN2NqSlVy?= =?utf-8?B?WDdiLzBQVjV0T2F1RDNSNCtTQ1lrMFVGNFhXOTZRek5TYlZ6bUVLd0daWmZw?= =?utf-8?B?NEsyU1JuR01TbHJtbGxoNmE5N1BtZUFxNzBxMnYvZ21mVHgxcDZSeHBoeUZQ?= =?utf-8?B?UDVEalJDV1ozc1doWGxzbGV0enJESHI4ZFdRQkFUcSszbDJlNlhqTmwrc1Mr?= =?utf-8?B?eHI4aGRrenplTjRVa0VYVEJyR1NjdUJzN09OTWZaMTQ0R3VDb3BXam1mR3FM?= =?utf-8?B?bzhIaUx0eDhmWmdDU1g4WUJ0Tkx2bUVxTk53akZsNTRGRC9XQzRGd1ZuemhP?= =?utf-8?B?WnVMTTZFeWlxb0dWVHZjWmlQdDh2K2pkUC9IbytyV250QTZqcklZQ2JoSTBF?= =?utf-8?B?QW9OblpacWxZZ3lkeDVDUFp2cjNiZXBWcmpjT3NmSXd2bHhhbDdNU3ZFcnVX?= =?utf-8?B?dW5YbzVmU3BpTndVRTVzSzBjQmkwUVdyZkxtK21sNS9pVmFlTEhVb0ZPQk9v?= =?utf-8?B?QmhzckxPdWo0d242QmdsajM2c0tQcUw4dFY0dDhTdTRkdnErWGRmRWNra1Fh?= =?utf-8?B?aXVqRFMycC93NmJCRVFxNzVaNnhVSWVCbTBJVUJsaWZYU2RHaHl1cm1WMURH?= =?utf-8?B?WHBZcldYRUoyRnY5RE9oUHlaeXFPczlBdEdMamlDWDdsQmpkZXhMdkxzTGM4?= =?utf-8?B?bThvdERUSWg0WE9LMFpuNW5iUEFDM3lrRXpqdVlEMzdrVERxNDNuczlqWEVy?= =?utf-8?B?N2grK1cvcGljcFhWa2JuZ3Q1NXBWODlRVEc2eGtsVFEwU2Y0STlCUk5XZlhQ?= =?utf-8?B?NnZ4dVJobThPT1JTcTFvbVFMdS83cXJ6Yk56aDJNMDFHc2JPRTMxUnlDbWVs?= =?utf-8?B?T3dFWDY5U2JodEFUUGtwQTU4eWE4N2Y1S2pHTDI1SkgwT3hzK3Y2M212elF5?= =?utf-8?B?WXFLN0lEQUxEZU1xc3JsZDBIWlNyM1NsbTFmdDlFU3RjdnoyTkpyeEpsRFFy?= =?utf-8?B?ZUdKUUQyWVdQMWFCYWMvVXU0SFo3VmNGYU1mOHdta1IwYWVWaGpJcEVVakZN?= =?utf-8?B?SENNS1hDYUNxU3FvQS9uaXY0dlRIaktYZVRBU01XelN5bXFxdGVEK21KYjJm?= =?utf-8?B?azFXaTMxU0M2UG85VzRrRUlxTFJKRlBpOC8rbUFhL24weHF1NlV6cUd4QnNo?= =?utf-8?B?RWt3QVFWSUlBeVViVnhBQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUhSN0pBcU56OXZCMHN6UFhvOUFhZWdWN0laS01relVtVVJqZHdPbGVGWi9u?= =?utf-8?B?TDdLNHNHb2xhM3o5ajRaenNWeHh1Zm1zaEQ3MUdlTnlSK0ZpQkQ1eGFEQzBP?= =?utf-8?B?bHRSa3ltZnA0RmlweUNFaEI0UTNabjhaQy9weGdiYVRXZEtiVW5MOVl5T1A5?= =?utf-8?B?YitLU1NFS0UrTXpDcTVnK0VIT1lUK2h3RGkzQWJTRVhaa0lBSENFZVk3TE9K?= =?utf-8?B?clc0cEpOcFJiWjBCS3NoZlVPWk1IZmNqYnhiSXNpUXdlbEtBZkw4V2ZPRWNm?= =?utf-8?B?SDhVemREWHc5Zms0VUI3SGt1aVFUQVBqWjNSVlRVRVprdGd5dmdVdTlLRjZG?= =?utf-8?B?dlNzbytLUnkxMkR5R0YyMFE1Nk5vMUFVTXB2UjBlRCt2VHhjQzdqY09jZ1Ro?= =?utf-8?B?Y1JqdTB1U3luMDlMYWZOVmx2K0w5SEU1bEtXcnFBMEhpNXFVVkdsL05adXFP?= =?utf-8?B?VUVhSENNUHp4cVhqUGtvNXBDdVZJS2ZiOXQrc1lZTTlEeEdCM0Q0d1I0Vi8r?= =?utf-8?B?WHJVM3NpMFJzelFXNVNZNUR5YTFMTGo4Y3ArdndUUElJRGIvU1k2MEVwV0VO?= =?utf-8?B?b0F0U0owdW1WbmFZRjQ5L2VrQkxDMWVDczFIdXB1MDNWZFNPM2cyVHR2emlK?= =?utf-8?B?d0tRRmZVMzlzb2lyWC9VRDVwdHR2TUE5dXNPOVNDT1pvV25FK3FYb3F3L1Ev?= =?utf-8?B?L1VPRjJEclhGMUJQaDliZVJyWkRudmhrS0xSV1ROeFphRVo3UTA4bHBhQXhG?= =?utf-8?B?STl6Uk14K1h0UWs2UlowWDg3RjBpc0ZMUkMvemgydE9LVFIxemJrbnVqM1Nl?= =?utf-8?B?bU4xcllxVzZHUTdXMkhVT0dhYUtSWkVTUXpkYVM1aUw3UHBDUVlPYXFIV0RE?= =?utf-8?B?dytBcG5JWGZaVUVqRzJSTHo4VXl3WUhrVXh1NFd2ek4zTGQxWjNvS0dLemFU?= =?utf-8?B?bkVacGgwYzV0Vi95MXY0VlNWNW8zdHY1VDZiZndLMTRjcDl4VElVSmFqSEth?= =?utf-8?B?NzUvbGo4TjlSOUlXZ2dNKzlZWG9LK3BMblYybG5LL0FEdFVsekhvN2ZoN045?= =?utf-8?B?RHRIM0lRSHA1UXlWbTVFNk5LbW1uZ1FKTHBXMFU2dm93L3gvdHpDMG1BU1RH?= =?utf-8?B?Z29RdVBTVGhBSVNXalNzVzVDemVJejhkUDM3cDZQZ09mUVc5d1MrNEVCbGZJ?= =?utf-8?B?d1Z2QnNocmE2TGNQVHlCNTVWQkNNT1M5c1FKMGNzc1p0S3gwWXZEUC8rMERh?= =?utf-8?B?R1FhWDFMd0hGUTB4MTJGRG1iZjZSOVRrU0hoQ0ZDOHZwbzVTS2tPWUpaMlA5?= =?utf-8?B?TkpQOHoxRGVYYXdhT0NhQVd4L0ZWd09QTC94VEkvaDE5bk4zdWRTWnpFNHlF?= =?utf-8?B?K0pjd3AxZVBSV1E1L3hEeTRlbEwxMVlqMkF3MXVQK00wSVREZjhrUHFYSmov?= =?utf-8?B?SkZOWG53RzY0bkE4R2d5QllvN1ZvNVlYSXkyb2VTbDh6Y0dnRzZESXkxVjk3?= =?utf-8?B?ZHhvM3E1RFhDejNqYk00bHR0bXA3cDJLckwvUmFCM2FGV3RzZWhTMzE5TVlD?= =?utf-8?B?ZllnOG4reklzV3lhTDlQTHdWRVJNV1BDVy9hZ2JQa1ZIRmg0aVp5eDlCc09H?= =?utf-8?B?K05GcmFvQjVSK0NmWUp3TVlrOXhUNDgrT3ZBU2tTcDNsbE5ERm5ZTktEZ01J?= =?utf-8?B?ZUEzWVNGV3BoVXd5ODN1blAxYzVrV2ljdjMwOExQYWtCbTBzOUdJdVJPMTlS?= =?utf-8?B?Snl5MXN2clE3WnRrSEpjT2ptYzUrT3IxMGtQZ0U1WTJ4SFNheEhkWHJoOFZk?= =?utf-8?B?cGpGcXZ5V2VPSEw2ZUZwRk94cHczQTdPd1VISS82UEljekhKWlllem5vUCti?= =?utf-8?B?RUttRzgzdkZsYkorSmFqeS84MmVGT0RwRHg2UlRwYTk4dmlVN29kWXVpS0p5?= =?utf-8?B?Tm1nWDViSVRUVzdQMFU2WjhOU0ZkdllqcHhMa3dYT2d5RjVxc25ldHphQ0g3?= =?utf-8?B?dnlVMnFSL0xsSGxIdTRuNkVqL3VKSE1lMDcvd0tnYjJabksreTF1UHlpOEQx?= =?utf-8?B?dklUN1BuOEdHNjlVVUY0VmJWU3VSM0N1K1BWMEV6USt3TlZpeDYvZnFBYmFX?= =?utf-8?B?eWZxd0UwTnB4N1lCMTA4R1g5MUloSG1RUExTdkFjVEoxbUMzWFc0NVVmc3k5?= =?utf-8?B?UEE9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1171ca48-7a79-4d37-1613-08dc9abc0fc6 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2024 17:26:09.2856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CEWC/LIyLG6iEnxOK+UUHgTx8xH6mBnKY9/U0UHecT+R/5CzebHAkPzRxprc3LZbF5/ATwv1LyFJZ8VFfLqm3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7069 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 02-07-2024 20:41, Stephen Hemminger wrote: > On Tue, 2 Jul 2024 16:10:13 +0530 > Hemant Agrawal wrote: > >> >> - printf("\n JD before conversion\n"); >> + fprintf(stdout, "\n JD before conversion\n"); >> for (i = 0; i < 12; i++) >> - printf("\n 0x%08x", ctx->jobdes.desc[i]); >> + fprintf(stdout, "\n 0x%08x", ctx->jobdes.desc[i]); > Don't see the point of this change, printf() and fprintf(stdout) are same thing. Yes, but no harm in this change. It was originally a script based change in the files. Now the code is consistent - only using fprintf. Either with f or with stdout.