From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 207F258F7 for ; Thu, 15 Jan 2015 14:34:49 +0100 (CET) Received: by mail-wi0-f177.google.com with SMTP id l15so17843209wiw.4 for ; Thu, 15 Jan 2015 05:34:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=LZTrgcJuOWno1ICySx6M75NyabgMexwuhp+Kjc0UCU8=; b=lEwHZW6T27XSObtJkwmTvz9eZFADiSfzGyuRjvNMnyha6u0akPuqX0bbOXajghChne 8QY+20zuZh5blIkoowdrHMpECdQrMLG1HkgceN2u7d5kv4uJBQ+GK+KZITVrlLqxRaNg jSB07DE1ogqSsmMv07qatpv5kVxrSU8jVKd5i5AHwQoUwqfWA0DK/DKwyvPs2rZemjvu NQeKUGVg7/kfcxfQPIzZZjNy9nyLw8oie3Bvn3NYAJwoXxgyyumJwcWKV298zNqeui+n Bq6hY1WJsqxYteDxIsCGJERPtNvk4v3Ztwmx5KsJqHYRMV6TBTQlXKU+5Sw4MxE0GVKQ EH4w== X-Gm-Message-State: ALoCoQn7ZV/W7f6tVYDnFrl3i20BvklKwGXbHWBLI7uPvjZOEGiQIb0hkyi6RjYXPYSDSgNtGdEt X-Received: by 10.180.206.229 with SMTP id lr5mr60133987wic.74.1421328887979; Thu, 15 Jan 2015 05:34:47 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id b10sm2104089wjr.32.2015.01.15.05.34.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Jan 2015 05:34:47 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Date: Thu, 15 Jan 2015 14:34:24 +0100 Message-ID: <2401477.11STyzvieH@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <20141209083546.12e936b7@urahara> References: <20141209083546.12e936b7@urahara> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] rte_log: remove unnecessary stubs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 13:34:49 -0000 > The read/seek/close stub functions are unnecessary on the > log stream. Per glibc fopencookie man page: > > cookie_read_function_t *read > If *read is a null pointer, then reads from the custom stream > always return end of file. > > cookie_seek_function_t *seek > If *seek is a null pointer, then it is not possible to perform > seek operations on the stream. > > cookie_close_function_t *close > If *close is NULL, then no special action is performed when the > stream is closed. > > Signed-off-by: Stephen Hemminger Acked-by: Thomas Monjalon Applied Thanks -- Thomas