From: Thomas Monjalon <thomas@monjalon.net>
To: "Yang, Zhiyong" <zhiyong.yang@intel.com>,
"Liu, Yong" <yong.liu@intel.com>
Cc: dev@dpdk.org, "Wang, Zhihong" <zhihong.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] mk: using initial-exec model for thread local variable
Date: Fri, 18 May 2018 11:46:57 +0200 [thread overview]
Message-ID: <2401955.4lgGG0bg7M@xps> (raw)
In-Reply-To: <E182254E98A5DA4EB1E657AC7CB9BD2A8B0B4438@BGSMSX101.gar.corp.intel.com>
28/04/2018 06:39, Yang, Zhiyong:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marvin Liu
> Sent: Saturday, April 28, 2018 5:54 PM
> >
> > When building share library, thread-local storage model will be changed to
> > global-dynamic. It will cost additional protect for read thread local variable. By
> > now only lcore id is this kind of varaible and not need to dynamic share with
> > other threads. So make TLS model back to initial-exec like static library for
> > better performance.
> >
> > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> >
>
> For vhost-user,
> If no this pach, vhost user in shared lib perf drops 14.3% than working in static.
> after applying the patch , vhost-user in shared lib can achieve the similar perf as in static lib.
>
> Tested-by: Zhiyong Yang <zhiyong.yang@intel.com>
For the record, I have decided to not try this optimization
in the last weeks of the 18.05 release.
However we could try it in 18.08 by applying the patch early in the cycle.
Is there anyone against this patch?
next prev parent reply other threads:[~2018-05-18 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-28 9:54 Marvin Liu
2018-04-28 4:39 ` Yang, Zhiyong
2018-05-18 9:46 ` Thomas Monjalon [this message]
2018-07-05 14:13 Marvin Liu
2018-07-05 9:25 ` Thomas Monjalon
2018-07-05 14:46 ` Sachin Saxena
2018-07-06 2:22 ` Liu, Yong
2018-07-06 10:02 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2401955.4lgGG0bg7M@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).