From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9689E4545B; Fri, 14 Jun 2024 23:12:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D3DF40674; Fri, 14 Jun 2024 23:12:15 +0200 (CEST) Received: from fout2-smtp.messagingengine.com (fout2-smtp.messagingengine.com [103.168.172.145]) by mails.dpdk.org (Postfix) with ESMTP id B1D0A4060B for <dev@dpdk.org>; Fri, 14 Jun 2024 23:12:14 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id 38EFB1380061; Fri, 14 Jun 2024 17:12:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 14 Jun 2024 17:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1718399534; x=1718485934; bh=63YcjM9OXUANhE8sxYWOzj5JaNbVXvrQWTw5QFvGvMo=; b= Ppn7UD76hmhK+7I6eIOE4H0M6LKo56xz3c85ufHQAU9nvqmdp2b0MoYQu7CQaLr/ F70NuFL5Sv0j4l4lTMlFpuXE/YtnIF71QuYJAdMHlBlK99l88wfwgzNhQedsLvVi eU/IYl9+JWisyYDgcrAkZL3aNTWOaKG3r4eusj8L0DH0zhNPFrPh2pF2qkb3LLYE hjlYTu+TmMp6RFqoBtSMrw2hKeVxhGFfRTuCEyLXu2S8gU/vFCSThigqhakbT5Wm sZkQxkFQLU7ME3U4SYNpQplvXO8bAyX5e380PIifbRf8M+DlQtjnpfBOutjr3wNg JwU+yNwgzCr/jD4or7lfYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1718399534; x= 1718485934; bh=63YcjM9OXUANhE8sxYWOzj5JaNbVXvrQWTw5QFvGvMo=; b=e 32+Mpi6AI572yTqQYyhuMZTVSvkvIXpQ7DgA0q7pE5RF4TdhXFqZA7snRMHHL56s /xafhrOG8LmynjLH31/NlNzL8zrmxeNYYz9nIw198gq7kC0ucuQSL6SSSn0+tKTk O21h39WVQv30JwxAIZIPimRYFNwaPEr2XbZ/XEteX91WJzlB7n0oLXRBllLiXAJE F0q/61W0D41tNEe4oM+ZXMUmcHCXEazWKZQytRdIJcvqe9VietUhvk1RhPjvn2vZ mHBrpBfKuE0KSCDGMJq6EmL6qRqPY9US9QrqBURUimTl1MYy070c5qE1gNPcQg+m ghi1N3Usu7SRbfwu2IHog== X-ME-Sender: <xms:LrJsZmmlXJ3C3-cfnPQbfh2Y3yzKdxEwu8r4P6kjqDQ1EMhMxVoKkQ> <xme:LrJsZt3f0A8uPYQ6s6-uD51TNVXSfpBaysQaavSOVMWwxYP5zlvvXTQ6t-kkj2XMT eKEgGHfpP9ih27pPw> X-ME-Received: <xmr:LrJsZko3LGKuGXMxfSGs9w_XjWgaxyrDoIZFMAQC82ueDEa72VKz83C-FXBfifXtR35C3W1mQ2DkKNzmqaHkhCTWPA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeduledgudehkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeeg kefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:LrJsZqlym-87p23XLtatntu9Kbt2ibdGAVcB5J4Vt06He85YaFpysg> <xmx:LrJsZk1sQywpAyMVuOURbA5pk7Oz9cYYTz06Ez4THS_OWrNvTLU8KA> <xmx:LrJsZhvn5ImagYoaTCeW8IPpYYYk00HgJYUQpuPXnFpWoUD2C9e7Bg> <xmx:LrJsZgU6mkeP6MKVOJfvW8KRAXopcale76D4NjHA1j25uBbnKocz_Q> <xmx:LrJsZuo20qzPjfRxQJI8ZQxVMm2DHc1xNTWgRGuVwq73HlzN5otrcd5T> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Jun 2024 17:12:13 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: maxime.coquelin@redhat.com, Hernan Vargas <hernan.vargas@intel.com>, nicolas.chautru@intel.com Cc: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Subject: Re: [PATCH v2 5/5] baseband/acc: cosmetic log changes Date: Fri, 14 Jun 2024 23:12:11 +0200 Message-ID: <2402510.9XhxPE3A7Q@thomas> In-Reply-To: <4775841.neEnAmRlxL@thomas> References: <20240502204548.236729-1-hernan.vargas@intel.com> <20240502204548.236729-6-hernan.vargas@intel.com> <4775841.neEnAmRlxL@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 14/06/2024 23:04, Thomas Monjalon: > 02/05/2024 22:45, Hernan Vargas: > > - rte_bbdev_log(WARNING, "DMA Response %#"PRIx32"\n", desc->req.word0); > > + rte_bbdev_log(WARNING, "DMA Response %#"PRIx32"", desc->req.word0); > > Why keeping an empty string after PRIx32? Should I remove it when pulling? > The title should be about removing superfluous empty line? I'm quite sure answers are "yes", so I move forward. Also please rename log functions in all bbdev PMDs as they are defined inside the drivers. For instance you should rename rte_bbdev_log to acc_log in this driver. Same for rte_bbdev_log_debug.