From: Thomas Monjalon <thomas@monjalon.net>
To: Phil Yang <phil.yang@arm.com>, jgrajcia@cisco.com
Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com,
gavin.hu@arm.com, honnappa.nagarahalli@arm.com, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH] net/memif: fix multi-process device probe error
Date: Tue, 06 Aug 2019 10:08:05 +0200 [thread overview]
Message-ID: <2404131.uETaXi0Jkk@xps> (raw)
In-Reply-To: <4150673.WUjg2Ml5sm@xps>
02/08/2019 23:01, Thomas Monjalon:
> 01/08/2019 12:35, Phil Yang:
> > Fixes: c41a04958b ("net/memif: support multi-process")
> >
> > Signed-off-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> > --- a/drivers/net/memif/rte_eth_memif.c
> > +++ b/drivers/net/memif/rte_eth_memif.c
> > @@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev)
> > eth_dev->dev_ops = &ops;
> > eth_dev->device = &vdev->device;
> > eth_dev->rx_pkt_burst = eth_memif_rx;
> > - eth_dev->tx_pkt_burst = eth_memif_rx;
> > + eth_dev->tx_pkt_burst = eth_memif_tx;
>
> It is not a probe error, but malfunctioning device, right?
> What is the current behaviour? You could better explain
> the symptom in the commit log, and the root cause (typo).
Nobody is replying or sending a v2?
Jakub?
next prev parent reply other threads:[~2019-08-06 8:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 10:35 Phil Yang
2019-08-02 21:01 ` Thomas Monjalon
2019-08-06 8:08 ` Thomas Monjalon [this message]
2019-08-06 8:18 ` Phil Yang (Arm Technology China)
2019-08-06 8:45 ` [dpdk-dev] [PATCH v2] net/memif: fix multi-process malfunctioning device Phil Yang
2019-08-06 9:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2404131.uETaXi0Jkk@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jgrajcia@cisco.com \
--cc=nd@arm.com \
--cc=phil.yang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).