From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 621CFA00E6 for ; Sun, 7 Jul 2019 21:55:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D4049324D; Sun, 7 Jul 2019 21:55:07 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BC286322C for ; Sun, 7 Jul 2019 21:55:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DCF6821583; Sun, 7 Jul 2019 15:55:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 07 Jul 2019 15:55:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=pPU3SzfGYLnhABkAbLjCCcu6G0rSBzisr/2Li1l07+U=; b=QsVTDRM3iC8Q HCmA39DtRQ7LL3ZHwpYql+XTtmQoZOjyo34t98gXaQxvM/H6g7DHsZ2gT/EqtMyb mRRcuwozJKSudaJQHS1n1Jt6b+G8JLn016E/F56BJqbJphrbqpscbjjDfaFrLw3M wADAS2YITYZmnamOYTsa0sRhNkbIdSc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=pPU3SzfGYLnhABkAbLjCCcu6G0rSBzisr/2Li1l07 +U=; b=SbJSwp1OE+ofCHLHTHzj9F2bbXNCawbvsFYy81LgWkLJHhaSFK3c8m70g jAoaG+v6CTrbwONIQ/nQ4amKPDWNusq8KrLVgAp3NC/no5jBQUZlBmIEwYyF0rJB lsrTkg6WqJVPi6cZ2p7xp3WW/9J6R0XYRe4lAZOCoj6HQdxg4JDW/kaYHGkgeOOm 8eqqB109gY4rDvhvEc9u6gzhZQs2i7uA7SYlXrIJp88svEQxzyXhbPeiVf9iRNbr 31wfVhCAnMI+XBwCiqyDiUsu1BjUZ/6cCvd2z46aSGamlgKEG/Oi3EfXDZrU62yd AcqRx2icNr729MY2p5/L53hCG/C/A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfeekgddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 75C9F380074; Sun, 7 Jul 2019 15:55:04 -0400 (EDT) From: Thomas Monjalon To: Hemant Agrawal , Sachin Saxena Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Sun, 07 Jul 2019 21:55:01 +0200 Message-ID: <2405365.jZWnX8O1rY@xps> In-Reply-To: <20190627093343.5171-6-hemant.agrawal@nxp.com> References: <20190625104411.19565-1-hemant.agrawal@nxp.com> <20190627093343.5171-1-hemant.agrawal@nxp.com> <20190627093343.5171-6-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 5/5] mempool/dpaa2: vfio dmamap for user allocated memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, please see several comments about formatting below. The title should start with a verb. VFIO and DMA should be uppercase. 27/06/2019 11:33, Hemant Agrawal: > From: Sachin Saxena > > Signed-off-by: Sachin Saxena There is no description in this patch. > --- a/drivers/bus/fslmc/fslmc_vfio.c > +++ b/drivers/bus/fslmc/fslmc_vfio.c > +__rte_experimental > +int rte_fslmc_vfio_mem_dmamap(uint64_t vaddr, uint64_t iova, uint64_t size) The new policy forbids __rte_experimental tag in .c file. Per coding style, the return type should be on a separate line.