* [dpdk-dev] [PATCH 0/2] pci: a couple more cleanups @ 2018-05-21 16:41 Stephen Hemminger 2018-05-21 16:41 ` [dpdk-dev] [PATCH 1/2] pci: make rte_pci_remove_device static Stephen Hemminger 2018-05-21 16:41 ` [dpdk-dev] [PATCH 2/2] pci: remove unused function prototype Stephen Hemminger 0 siblings, 2 replies; 6+ messages in thread From: Stephen Hemminger @ 2018-05-21 16:41 UTC (permalink / raw) To: dev; +Cc: Stephen Hemminger This is follow on to earlier PCI patches to remove unused functions Stephen Hemminger (2): pci: make rte_pci_remove_device static pci: remove unused function prototype drivers/bus/pci/pci_common.c | 5 ++++- drivers/bus/pci/private.h | 20 -------------------- 2 files changed, 4 insertions(+), 21 deletions(-) -- 2.17.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 1/2] pci: make rte_pci_remove_device static 2018-05-21 16:41 [dpdk-dev] [PATCH 0/2] pci: a couple more cleanups Stephen Hemminger @ 2018-05-21 16:41 ` Stephen Hemminger 2018-05-22 9:00 ` Gaëtan Rivet 2018-05-21 16:41 ` [dpdk-dev] [PATCH 2/2] pci: remove unused function prototype Stephen Hemminger 1 sibling, 1 reply; 6+ messages in thread From: Stephen Hemminger @ 2018-05-21 16:41 UTC (permalink / raw) To: dev; +Cc: Stephen Hemminger Only used in one file, and therefore can be made static. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- drivers/bus/pci/pci_common.c | 5 ++++- drivers/bus/pci/private.h | 10 ---------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 7215aaec3add..d3ac04a8f00f 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -26,6 +26,9 @@ #include "private.h" + +static void rte_pci_remove_device(struct rte_pci_device *pci_device); + extern struct rte_pci_bus rte_pci_bus; #define SYSFS_PCI_DEVICES "/sys/bus/pci/devices" @@ -445,7 +448,7 @@ rte_pci_insert_device(struct rte_pci_device *exist_pci_dev, } /* Remove a device from PCI bus */ -void +static void rte_pci_remove_device(struct rte_pci_device *pci_dev) { TAILQ_REMOVE(&rte_pci_bus.device_list, pci_dev, next); diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h index 88fa587e74dc..02e2fb44367f 100644 --- a/drivers/bus/pci/private.h +++ b/drivers/bus/pci/private.h @@ -93,16 +93,6 @@ void rte_pci_add_device(struct rte_pci_device *pci_dev); void rte_pci_insert_device(struct rte_pci_device *exist_pci_dev, struct rte_pci_device *new_pci_dev); -/** - * Remove a PCI device from the PCI Bus. This sets to NULL the bus references - * in the PCI device object as well as the generic device object. - * - * @param pci_device - * PCI device to be removed from PCI Bus - * @return void - */ -void rte_pci_remove_device(struct rte_pci_device *pci_device); - /** * Update a pci device object by asking the kernel for the latest information. * -- 2.17.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] pci: make rte_pci_remove_device static 2018-05-21 16:41 ` [dpdk-dev] [PATCH 1/2] pci: make rte_pci_remove_device static Stephen Hemminger @ 2018-05-22 9:00 ` Gaëtan Rivet 0 siblings, 0 replies; 6+ messages in thread From: Gaëtan Rivet @ 2018-05-22 9:00 UTC (permalink / raw) To: Stephen Hemminger; +Cc: dev Hello Stephen, On Mon, May 21, 2018 at 09:41:49AM -0700, Stephen Hemminger wrote: > Only used in one file, and therefore can be made static. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com> > --- > drivers/bus/pci/pci_common.c | 5 ++++- > drivers/bus/pci/private.h | 10 ---------- > 2 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c > index 7215aaec3add..d3ac04a8f00f 100644 > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -26,6 +26,9 @@ > > #include "private.h" > > + > +static void rte_pci_remove_device(struct rte_pci_device *pci_device); > + > extern struct rte_pci_bus rte_pci_bus; > > #define SYSFS_PCI_DEVICES "/sys/bus/pci/devices" > @@ -445,7 +448,7 @@ rte_pci_insert_device(struct rte_pci_device *exist_pci_dev, > } > > /* Remove a device from PCI bus */ > -void > +static void > rte_pci_remove_device(struct rte_pci_device *pci_dev) > { > TAILQ_REMOVE(&rte_pci_bus.device_list, pci_dev, next); > diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h > index 88fa587e74dc..02e2fb44367f 100644 > --- a/drivers/bus/pci/private.h > +++ b/drivers/bus/pci/private.h > @@ -93,16 +93,6 @@ void rte_pci_add_device(struct rte_pci_device *pci_dev); > void rte_pci_insert_device(struct rte_pci_device *exist_pci_dev, > struct rte_pci_device *new_pci_dev); > > -/** > - * Remove a PCI device from the PCI Bus. This sets to NULL the bus references > - * in the PCI device object as well as the generic device object. > - * > - * @param pci_device > - * PCI device to be removed from PCI Bus > - * @return void > - */ > -void rte_pci_remove_device(struct rte_pci_device *pci_device); > - > /** > * Update a pci device object by asking the kernel for the latest information. > * > -- > 2.17.0 > -- Gaëtan Rivet 6WIND ^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 2/2] pci: remove unused function prototype 2018-05-21 16:41 [dpdk-dev] [PATCH 0/2] pci: a couple more cleanups Stephen Hemminger 2018-05-21 16:41 ` [dpdk-dev] [PATCH 1/2] pci: make rte_pci_remove_device static Stephen Hemminger @ 2018-05-21 16:41 ` Stephen Hemminger 2018-05-22 9:00 ` Gaëtan Rivet 1 sibling, 1 reply; 6+ messages in thread From: Stephen Hemminger @ 2018-05-21 16:41 UTC (permalink / raw) To: dev; +Cc: Stephen Hemminger Prototype for pci_unbind_kernel_driver exists but no code. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- drivers/bus/pci/private.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h index 02e2fb44367f..680879ed35a2 100644 --- a/drivers/bus/pci/private.h +++ b/drivers/bus/pci/private.h @@ -106,16 +106,6 @@ void rte_pci_insert_device(struct rte_pci_device *exist_pci_dev, */ int pci_update_device(const struct rte_pci_addr *addr); -/** - * Unbind kernel driver for this device - * - * This function is private to EAL. - * - * @return - * 0 on success, negative on error - */ -int pci_unbind_kernel_driver(struct rte_pci_device *dev); - /** * Map the PCI resource of a PCI device in virtual memory * -- 2.17.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] pci: remove unused function prototype 2018-05-21 16:41 ` [dpdk-dev] [PATCH 2/2] pci: remove unused function prototype Stephen Hemminger @ 2018-05-22 9:00 ` Gaëtan Rivet 2018-06-27 16:37 ` Thomas Monjalon 0 siblings, 1 reply; 6+ messages in thread From: Gaëtan Rivet @ 2018-05-22 9:00 UTC (permalink / raw) To: Stephen Hemminger; +Cc: dev On Mon, May 21, 2018 at 09:41:50AM -0700, Stephen Hemminger wrote: > Prototype for pci_unbind_kernel_driver exists but no code. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com> > --- > drivers/bus/pci/private.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h > index 02e2fb44367f..680879ed35a2 100644 > --- a/drivers/bus/pci/private.h > +++ b/drivers/bus/pci/private.h > @@ -106,16 +106,6 @@ void rte_pci_insert_device(struct rte_pci_device *exist_pci_dev, > */ > int pci_update_device(const struct rte_pci_addr *addr); > > -/** > - * Unbind kernel driver for this device > - * > - * This function is private to EAL. > - * > - * @return > - * 0 on success, negative on error > - */ > -int pci_unbind_kernel_driver(struct rte_pci_device *dev); > - > /** > * Map the PCI resource of a PCI device in virtual memory > * > -- > 2.17.0 > -- Gaëtan Rivet 6WIND ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] pci: remove unused function prototype 2018-05-22 9:00 ` Gaëtan Rivet @ 2018-06-27 16:37 ` Thomas Monjalon 0 siblings, 0 replies; 6+ messages in thread From: Thomas Monjalon @ 2018-06-27 16:37 UTC (permalink / raw) To: Stephen Hemminger; +Cc: dev, Gaëtan Rivet 22/05/2018 11:00, Gaëtan Rivet: > On Mon, May 21, 2018 at 09:41:50AM -0700, Stephen Hemminger wrote: > > Prototype for pci_unbind_kernel_driver exists but no code. > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com> It was a leftover of an old incomplete cleanup. Applied, thanks ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-27 16:37 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-05-21 16:41 [dpdk-dev] [PATCH 0/2] pci: a couple more cleanups Stephen Hemminger 2018-05-21 16:41 ` [dpdk-dev] [PATCH 1/2] pci: make rte_pci_remove_device static Stephen Hemminger 2018-05-22 9:00 ` Gaëtan Rivet 2018-05-21 16:41 ` [dpdk-dev] [PATCH 2/2] pci: remove unused function prototype Stephen Hemminger 2018-05-22 9:00 ` Gaëtan Rivet 2018-06-27 16:37 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).