From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: "Bruce Richardson" <bruce.richardson@intel.com>,
dpdk-dev <dev@dpdk.org>,
"David Marchand" <david.marchand@redhat.com>,
"Ferruh Yigit" <ferruh.yigit@intel.com>,
"Olivier Matz" <olivier.matz@6wind.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
"Ajit Khaparde" <ajit.khaparde@broadcom.com>,
"Jerin Jacob" <jerinj@marvell.com>,
"Hemant Agrawal" <hemant.agrawal@nxp.com>,
"Ray Kinsella" <mdr@ashroe.eu>,
"Neil Horman" <nhorman@tuxdriver.com>,
"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
"Kiran Kumar K" <kirankumark@marvell.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half
Date: Mon, 09 Nov 2020 15:02:52 +0100 [thread overview]
Message-ID: <2407553.B4KgyuXQMY@thomas> (raw)
In-Reply-To: <CALBAE1OGm2qJwt14Y1eDqRR6DO-GriipoqDJVAqZdGaOzPeYsw@mail.gmail.com>
09/11/2020 14:35, Jerin Jacob:
> On Mon, Nov 9, 2020 at 6:29 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 09/11/2020 13:01, Jerin Jacob:
> > > Hi @Thomas Monjalon
> > >
> > > Any specific reason why you removed the static assert from octeontx2.
> >
> > I have a build failure when cross-compiling for octeontx2.
I was wrong here.
> I am trying the below command, I am not able to see any issue
> meson build --cross-file config/arm/arm64_octeontx2_linux_gcc
>
> Are you facing the issue with 32bit? Could you share the steps to
> reproduce and gcc version?
Oh you're right, the issue was with 32-bit build,
sorry for the confusion.
> --- a/drivers/net/octeontx2/otx2_ethdev.c
> +++ b/drivers/net/octeontx2/otx2_ethdev.c
> @@ -749,7 +749,7 @@ nix_tx_offload_flags(struct rte_eth_dev *eth_dev)
> RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=
> offsetof(struct rte_mbuf, ol_flags) + 12);
> RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, tx_offload) !=
> - offsetof(struct rte_mbuf, pool) + 2 * sizeof(void *));
> + offsetof(struct rte_mbuf, pool) + 2 * sizeof(uint64_t));
The actual "fix" is
offsetof(struct rte_mbuf, pool) + sizeof(uint64_t) + sizeof(void *)
I don't understand the octeontx2 vector code.
Please check what is the impact of this offset change.
BTW, is 32-bit build really supported with octeontx2?
next prev parent reply other threads:[~2020-11-09 14:03 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 15:53 Thomas Monjalon
2020-11-07 17:12 ` Jerin Jacob
2020-11-07 18:39 ` Thomas Monjalon
2020-11-07 19:05 ` Jerin Jacob
2020-11-07 20:33 ` Thomas Monjalon
2020-11-09 5:18 ` Jerin Jacob
2020-11-09 8:04 ` Thomas Monjalon
2020-11-09 8:27 ` Jerin Jacob
2020-11-09 9:47 ` Bruce Richardson
2020-11-09 12:01 ` Jerin Jacob
2020-11-09 12:59 ` Thomas Monjalon
2020-11-09 13:35 ` Jerin Jacob
2020-11-09 14:02 ` Thomas Monjalon [this message]
2020-11-09 14:08 ` Jerin Jacob
2020-11-09 14:42 ` Thomas Monjalon
2020-11-09 14:53 ` Jerin Jacob
2020-11-09 8:16 ` Morten Brørup
2020-11-09 10:06 ` [dpdk-dev] [dpdk-techboard] " Bruce Richardson
2020-11-09 10:21 ` Morten Brørup
2020-11-09 18:04 ` Stephen Hemminger
2020-11-10 7:15 ` Morten Brørup
2020-11-07 18:57 ` [dpdk-dev] " Morten Brørup
2020-11-09 10:08 ` Bruce Richardson
2020-11-09 10:30 ` Morten Brørup
2020-11-09 10:33 ` Ananyev, Konstantin
2020-11-09 10:36 ` Bruce Richardson
2020-11-09 11:24 ` Ananyev, Konstantin
2020-11-09 21:29 ` [dpdk-dev] [PATCH v2 0/2] move mbuf pool pointer Thomas Monjalon
2020-11-09 21:29 ` [dpdk-dev] [PATCH v2 1/2] drivers: disable OCTEON TX2 in 32-bit build Thomas Monjalon
2020-11-10 18:05 ` Jerin Jacob
2020-11-09 21:29 ` [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half Thomas Monjalon
2020-11-10 10:05 ` Morten Brørup
2020-11-10 10:44 ` Thomas Monjalon
2020-11-10 16:25 ` Olivier Matz
2020-11-10 18:06 ` Jerin Jacob
2020-11-12 14:39 ` Thomas Monjalon
2020-11-10 18:08 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2407553.B4KgyuXQMY@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=kirankumark@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=mdr@ashroe.eu \
--cc=ndabilpuram@marvell.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).