From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix shared lib build with stable abi
Date: Mon, 13 Jul 2015 11:32:07 +0200 [thread overview]
Message-ID: <2407649.DHIu0SHXnf@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2F6B302@IRSMSX103.ger.corp.intel.com>
> > When next ABI is enabled, the shared lib extension is .so.x.1.
> > That's why a double basename was introduced.
> > But the "ifeq NEXT_ABI" was forgotten, removing the .so extension when
> > NEXT_ABI is disabled.
> > It was preventing the linker from finding the .so libraries.
> >
> > Fixes: 506f51cc0da7 ("mk: enable next abi preview")
> >
> > Reported-by: John McNamara <john.mcnamara@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> That fixes it. Thanks.
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks.
Now that next ABI can be disabled, patches using it may be applied :)
next prev parent reply other threads:[~2015-07-13 9:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 22:05 [dpdk-dev] [PATCH] mk: enable next abi in static libs Thomas Monjalon
2015-07-06 13:18 ` Thomas Monjalon
2015-07-06 13:35 ` Neil Horman
2015-07-06 13:49 ` Thomas Monjalon
2015-07-06 18:22 ` Neil Horman
2015-07-06 21:44 ` Thomas Monjalon
2015-07-07 11:14 ` Neil Horman
2015-07-07 12:46 ` Thomas Monjalon
2015-07-07 13:11 ` Neil Horman
2015-07-07 13:44 ` Neil Horman
2015-07-10 16:07 ` Mcnamara, John
2015-07-11 14:19 ` Neil Horman
2015-07-13 10:14 ` Mcnamara, John
2015-07-08 14:55 ` [dpdk-dev] [PATCH v2 0/2] next abi option Thomas Monjalon
2015-07-08 14:55 ` [dpdk-dev] [PATCH v2 1/2] mk: remove variables identical to config ones Thomas Monjalon
2015-07-08 14:55 ` [dpdk-dev] [PATCH v2 2/2] mk: enable next abi preview Thomas Monjalon
2015-07-08 16:44 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2015-07-13 7:32 ` Mcnamara, John
2015-07-13 8:48 ` Thomas Monjalon
2015-07-13 9:02 ` [dpdk-dev] [PATCH] mk: fix shared lib build with stable abi Thomas Monjalon
2015-07-13 9:24 ` Mcnamara, John
2015-07-13 9:32 ` Thomas Monjalon [this message]
2015-07-08 16:50 ` [dpdk-dev] [PATCH v2 0/2] next abi option Neil Horman
2015-07-08 22:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2407649.DHIu0SHXnf@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).