From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D03D7A0A02; Wed, 24 Mar 2021 12:01:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C6D740683; Wed, 24 Mar 2021 12:01:34 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 598104067B for ; Wed, 24 Mar 2021 12:01:32 +0100 (CET) IronPort-SDR: CWYPzW/EvfYUp57mgLFY9gDCnCzX0EB5ufNnNt8UmnXUMqxTuSSewBaU/6LogzleqPEY+6RVgG 328A19MWQ2+g== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="190091309" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="190091309" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 04:01:31 -0700 IronPort-SDR: 6CTzUdHQTuPbAFkmhcnqDHnfMTt44afN1tAJGpQhzYVZWSTk+8EYBs7vzoEgPcwqbH33WgnSGm XIbyNrJ9zBog== X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="408791805" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.28.141]) ([10.252.28.141]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 04:01:30 -0700 From: Ferruh Yigit To: Jiawen Wu , dev@dpdk.org References: <20210316105149.110904-1-jiawenwu@trustnetic.com> <20210316105149.110904-3-jiawenwu@trustnetic.com> <9160c9a1-9b93-4fc8-6c39-5f807ea9722c@intel.com> X-User: ferruhy Message-ID: <240c5a36-61d8-1d62-0bb3-3c944026c724@intel.com> Date: Wed, 24 Mar 2021 11:01:29 +0000 MIME-Version: 1.0 In-Reply-To: <9160c9a1-9b93-4fc8-6c39-5f807ea9722c@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/7] net/txgbe: add device arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/24/2021 10:59 AM, Ferruh Yigit wrote: > On 3/16/2021 10:51 AM, Jiawen Wu wrote: >> Add device arguments to support runtime options. These arguments are >> only set for backplane NICs. >> >> Signed-off-by: Jiawen Wu > > <...> > >> + >> +#define TXGBE_DEVARG_BP_AUTO        "auto" >> +#define TXGBE_DEVARG_KR_POLL        "poll" >> +#define TXGBE_DEVARG_KR_PRESENT        "present" >> +#define TXGBE_DEVARG_KX_SGMII        "sgmii" >> +#define TXGBE_DEVARG_FFE_SET        "ffe_set" >> +#define TXGBE_DEVARG_FFE_MAIN        "ffe_main" >> +#define TXGBE_DEVARG_FFE_PRE        "ffe_pre" >> +#define TXGBE_DEVARG_FFE_POST        "ffe_post" >> + > > I just recognized that this patch is adding devargs without using them, and > later patches are using them. This separates them from the full context. > > Can you please add them gradually as they are used, in the same patch they are > used? > > Meanwhile you can add the release notes update in next version. > > Thanks, > ferruh And I think 'auto' can be 'auto_neg', since 'auto' is too generic, but up to you.