From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id BC0EC8E7E for ; Mon, 2 Nov 2015 17:24:20 +0100 (CET) Received: by wmeg8 with SMTP id g8so65222748wme.1 for ; Mon, 02 Nov 2015 08:24:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=xPgge3AVJ1GcrvDsrnf4MNCH3OChnG/rmjsUlwpGYoQ=; b=epMKzD4Z1UnNbOAtj/YE0c1e7vK8ymQpz/GcjexZWyYXTjZ3sreLSfIxjH71bYp2e0 OT5vuBSvzasYhQP0pB7p+bwquYxdSbZvnRakSM/0emns07vUqDf9yeSI4EbmWlNUt6qy lxOr+pTLfJ2kr05phRYkXYWgiyWwhwTxy3fxXPTFXGOaq0i1gXQKcsFJJp0FnuFkBn2T LgbHhA/wzyAhtwxtw8rMoGeZPOjDvO8FTm0hc4KV7KsrrZf1KM5TsDNHcURLfCzprv5d pY5HP6fDL4PZ+Pjej6x4RJxZD6mtwrsZfxfekesSBXNlyuPFypwop0gQ1Mj6mfWno+3K DHmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=xPgge3AVJ1GcrvDsrnf4MNCH3OChnG/rmjsUlwpGYoQ=; b=LLqncz1afdUbx7CjMxjDlSjIpcXBQkRWLA8zVIbYfVbgu0ovGZZRHttuG0TxgNvker aCYmvjyoutnjQ+OjO/BF1oHVy3oGJKA9vCJ42u6l//HRqzUC8z5RMDy57Z0PITgg6vnz 0LfV9pvrmsC0gu4ML/x7g2BUuqwaxxS64ATleaiOlLgQwfA7POA0ASr5fxE7rW3xtu3x ZFsKfOu76R0WMv7+15ojuXCmjdxDYKIQGJW1/FMdUEv3JwItg86u+KxYuNWQeQkL6uWp 7Wl3mLxzQyuKiSrOmlHV3fFHOGU2E7SRyCueURrB1deLVKTMpX1DgDsXxOAYgP9PSEKR lbRQ== X-Gm-Message-State: ALoCoQmrz5HrPaiDzd5LQ6lEkD5aU55LB2uH+VaaVUxTy3qbIHkMhsa+HfD9mljocgie68oHl4jJ X-Received: by 10.28.146.82 with SMTP id u79mr13739747wmd.96.1446481460640; Mon, 02 Nov 2015 08:24:20 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id gl4sm23158337wjd.49.2015.11.02.08.24.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2015 08:24:20 -0800 (PST) From: Thomas Monjalon To: "Van Haaren, Harry" Date: Mon, 02 Nov 2015 17:23:09 +0100 Message-ID: <2410133.CmQNrNzvTz@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1445528914-27636-2-git-send-email-harry.van.haaren@intel.com> <1625667.g6rLv7AGl4@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 02/10] ethdev: update xstats_get() strings and Q handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 16:24:20 -0000 2015-11-02 10:17, Van Haaren, Harry: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Monday, November 2, 2015 7:59 AM > > > + /* if xstats_get() is implemented by the PMD, the Q stats are done */ > > > + if (dev->dev_ops->xstats_get != NULL) > > > + return count + xcount; > > > + > > > /* per-rxq stats */ > > > for (q = 0; q < dev->data->nb_rx_queues; q++) { > > > for (i = 0; i < RTE_NB_RXQ_STATS; i++) { > > > > Please could you explain why the generic per-queue stats are not used when > > xstats is implemented in the driver? > > Each PMD exposes its own queue stats so it has the flexibility of presenting them exactly has the hardware counts, in a human-readable order. > > If the generic xstats were used, testpmd> xstats output would split a single queue's xstats to two places in the list. As stats are used during debugging, readability and clarity of the stats is vital in my opinion. Output control is the role of testpmd, not the driver. I think you can reorder the stats in testpmd given that you have defined a clear scheme naming (thanks).