From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 71E0BFE5 for ; Tue, 15 Dec 2015 18:07:41 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id n186so104887388wmn.0 for ; Tue, 15 Dec 2015 09:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=wFXRo1fWOQj+kFaHDF1ffhHYt1jFZM/M4FZCQBsmrs8=; b=G60cL4U+CI0ouGt2Y/K8T7+7TQqAtFxPOQe/e7uNcuxzi6Y5J18JIDMSBMAo/lO1E1 N1LGfWRlX0JC/pkWiNwhbTTgOaIHHU3yFMe/MPdX8mNWVaxHgk8CUX2icjeuZGZCwQni ixJIyMSZ7qIjvw7z/5T9utduYbGVor99n2Q7I5ZiI1Zat7SoSFLZelsIkJgYgg4jwHcv 3GsqBw93ELZ5OeX7uUmZyJ+UAIz5w70CHHvwldCHpGWacEHJ67vZQK9d3hPvQ2zfZuYP TmQmPn60A4fmM1BzMeOM0R64a8xygMXstu8m7oIcpGjJwfgdizLmAhpCQ4yHIqj5kGYu QmwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=wFXRo1fWOQj+kFaHDF1ffhHYt1jFZM/M4FZCQBsmrs8=; b=JntDIJiCyM4SugPlSPG78vLQxc/Yh+gqlh3wMqePlHtoIT2vHAQSW7Pae5zgmZNF2z JYCwJ1JN2JGoXNZhnccPrXG34mZnEsrnrmI+PltJC8QSTZKEWC4BBFCKZGj0ER6A0hU2 sS36YZ86S7oosyfg+/VUpGXJdJ3QfM35ehaKhcHC0a+3ikAoJij3m7tPIwbfX8u/XgQK BU2oBSM6arh5E94luMBCYb2JPUnfXAsufJoDX7mninTRj5e4MW5VhF4x4brDmdbq22If ENZ3ypSWIGv2epcc6J9u3PNAXGe48RLEj0wJnzPGbamqLSgxr+5dKnrz5ARLH2zfipSR 1DoQ== X-Gm-Message-State: ALoCoQn3amWn3XEA2UWgND8R4UCrrqzyhfsvNjeMgU8/9oxazM/b0AGUK1M3tIf7xllzIa/Ory/+3QySjxiN04lXrTdo3a29zg== X-Received: by 10.28.144.139 with SMTP id s133mr6161748wmd.90.1450199261248; Tue, 15 Dec 2015 09:07:41 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id c4sm2215533wjs.36.2015.12.15.09.07.40 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 15 Dec 2015 09:07:40 -0800 (PST) From: Thomas Monjalon To: Robin Jarry Date: Tue, 15 Dec 2015 18:06:24 +0100 Message-ID: <2411343.XAzfyo3F5c@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1450195501-9196-1-git-send-email-robin.jarry@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: restore imissed stat counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 17:07:41 -0000 2015-12-15 16:41, Van Haaren, Harry: > > From: Robin Jarry [mailto:robin.jarry@6wind.com] > > Subject: [PATCH] ixgbe: restore imissed stat counter > > > > This counter was left unmodified. Restore it in ixgbe_dev_stats_get. > > > > The ierrors counter still includes imissed for ixgbe. This behaviour is > > not consistent amongst all drivers. Another patch may be needed to unify > > the meaning of the ierrors counter. > > > > Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats") > > > > Signed-off-by: Robin Jarry > > There is work to be done to allow easier distinction between > drops due to the host, and errors due to bad packets. > > Until that work is done, write the dropped packet count to imissed, so: > > Acked-by: Harry van Haaren Applied, thanks