From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id AF52A1B346 for ; Tue, 13 Feb 2018 22:39:35 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4F09120ED1; Tue, 13 Feb 2018 16:39:35 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 13 Feb 2018 16:39:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=doKVevMnKiSB9M801Ea+f/PpAZ HQ3wf3vmogJNgYvMw=; b=fUqye2d01S99gLewIePdDxf9iCJ6n8FH71ydhWBD5q BNWlUK9Bh930DSJsRdL0/JGf1JfFfP+eWpygE3o6o6ShxJfBl8mw5DwT9KbGTFqA BeRcQCKasm8s9UQ01bOwo3zm0xU2FlCrqVr94SzxnlyZCwzCDISD4idqH0TRXXI+ I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=doKVev MnKiSB9M801Ea+f/PpAZHQ3wf3vmogJNgYvMw=; b=HfidcgM+Mpy6pF24sziM0K ZvWG5L0TB+hYDHWWTNUDnzrJS6w69xTN0l5dl5eBjPaQnoP438F4880EJfaqJ8gi PnDBiF1LwfDcsJO0ewLbouAM1w6WtEk06ucGpLa+Ey2t8dE2Ex5FU+UKYngVPkLo Y946cm4sbbMbdd5TMWz9QweUsemA2UszIeJ7WUI5za3rmUAIYwrNarfV2niRMQa/ lVJbL9YEaYx6g13Iy5dvEWdT4f8W1S88Goz7nAwzYvFaLOi11BC5QSwV4a0t7O6A dtTB3Oh64fxIC1Y6ku4rcxjDSBN8WgQ4zCQuF+o7m6XW8JGKa4W+xvm6ZtLWPxDA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D4D627E4E9; Tue, 13 Feb 2018 16:39:34 -0500 (EST) From: Thomas Monjalon To: matan@mellanox.com Cc: dev@dpdk.org, gaetan.rivet@6wind.com, Pablo de Lara Date: Tue, 13 Feb 2018 22:39:25 +0100 Message-ID: <2411842.iNoccj3r1V@xps> In-Reply-To: <20180213213312.22225-1-thomas@monjalon.net> References: <20180213213312.22225-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix FreeBSD build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 21:39:35 -0000 13/02/2018 22:33, Thomas Monjalon: > The type pthread_t is not portable because it is freely defined. > On Linux, it is an unsigned long int which can be printed with %l. Forgot to add: On FreeBSD, it is a pointer. That's why there was this error: drivers/net/failsafe/failsafe_private.h:377:53: error: format specifies type 'unsigned long' but the argument has type 'pthread_t' (aka 'struct pthread *') Reported-by: Pablo de Lara > > The debug printing of the thread id is restricted to Linux only. > > Fixes: 655fcd68c7d2 ("net/failsafe: fix hotplug races") > > Signed-off-by: Thomas Monjalon