From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id DD1075910 for ; Wed, 25 Jun 2014 12:04:48 +0200 (CEST) Received: by mail-wi0-f172.google.com with SMTP id hi2so7658056wib.17 for ; Wed, 25 Jun 2014 03:05:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=RN0XWCvEWfguG5QOzuY7nDcNd9s2UzcJsKHBKzXSdAQ=; b=gvacbT7IYAchW3UJu0hQgExdTD9s0x4zNZ8LY/J+ygyTHnTqkGoLx2cJSAbkgLop69 CbUkJ/BEpgnlzZBEcrPW2OKg1SC04e/EiWM8Z5UkqgC5ojCuAS1UVyJiVOxA8BFqMTHx wJCIL+rs74D97qsIqzgKOkyw4OO0LOB6QeRypWBHHDc1SAthn8rB8PYG47hSRa0LLj8L snGpIbxE1vzE6zioH5aF+bAeYDxq0dyU6KOsuLbFs/xpw9PI9jKNCNDpKyX6kxdlTGdg lejAxJkC3Ki5J6N4V4yRvbp5ZXPub2NNlCvFaYB9e5VPMDHcsZIkZ7PSJdp2WPRUkp7D l55Q== X-Gm-Message-State: ALoCoQkBQHmuNgv/bFF6vfu1Sykn9YBeFP29KMtrBqtxjZ4G3DrArO1xlkT28JNmcpTjNUcPEeNQ X-Received: by 10.194.119.228 with SMTP id kx4mr8687259wjb.108.1403690707067; Wed, 25 Jun 2014 03:05:07 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id na4sm51984739wic.21.2014.06.25.03.05.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jun 2014 03:05:06 -0700 (PDT) Date: Wed, 25 Jun 2014 03:05:06 -0700 (PDT) X-Google-Original-Date: Wed, 25 Jun 2014 12:05 +0200 From: Thomas Monjalon To: "Cao, Waterman" Message-ID: <2412606.IsDGqMgZ84@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD0110EB24@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD0110E674@BPXM14GP.gisp.nec.co.jp> <7F861DC0615E0C47A872E6F3C5FCDDBD0110EB24@BPXM14GP.gisp.nec.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org, Hayato Momma Subject: Re: [dpdk-dev] [PATCH] kni: compatibility with RHEL 7 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jun 2014 10:04:49 -0000 Hi Waterman, 2014-06-12 09:35, Hiroshi Shimamoto: > 2014-06-12 09:18, Cao, Waterman: > > Can you give details about Linux Kernel version and complier vers= ion? > > Because we tried to build code in the Redhat 7.0 before, but we d= on't > > meet this issue. Please see information as the following: > > Linux kernel 3.10.0-54.0.1.el7.x86_64 > > RHEL70BETA_64=09GCC 4.8.2 ICC: 14.0.0 >=20 > Yes, >=20 > Linux REHEL7RC-1 3.10.0-121.el7.x86_64 #1 SMP Tue Apr 8 10:48:19 EDT = 2014 > x86_64 x86_64 x86_64 GNU/Linux gcc version 4.8.2 20140120 (Red Hat > 4.8.2-16) (GCC) >=20 > I got the below error; > /path/to/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3851:1: er= ror: > conflicting types for =E2=80=98skb_set_hash=E2=80=99 skb_set_hash(str= uct sk_buff *skb, > __u32 hash, __always_unused int type) >=20 > /usr/src/kernels/3.10.0-121.el7.x86_64/include/linux/skbuff.h:762:1: = note: > previous definition of =E2=80=98skb_set_hash=E2=80=99 was here skb_se= t_hash(struct sk_buff > *skb, __u32 hash, enum pkt_hash_types type) Could you confirm this fix is needed and acknowledge it? Thanks > > -----Original Message----- > >=20 > > >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hiroshi Shima= moto > > >Sent: Thursday, June 12, 2014 4:10 PM > > >To: dev@dpdk.org > > >Cc: Hayato Momma > > >Subject: [dpdk-dev] [PATCH] kni: compatibility with RHEL 7 > > > > > >From: Hiroshi Shimamoto > > > > > >Compilation in RHEL7 is failed. This fixes the build issue. > > > > > >RHEL7 has skb_set_hash, the kernel version is 3.10 though. > > >Don't define skb_set_hash for RHEL7. > > > > > >Signed-off-by: Hiroshi Shimamoto > > >Reviewed-by: Hayato Momma > > >--- > > > > > > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > >diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > > >b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h index > > >4c27d5d..b4de6e2 100644 > > >--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > > >+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > > >@@ -3843,6 +3843,9 @@ static inline struct sk_buff > > >*__kc__vlan_hwaccel_put_tag(struct sk_buff *skb, #endif /* >=3D 3= .10.0>=20 > > */ > >=20 > > > #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,14,0) ) > > > > > >+ > > >+#if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >=3D > > >+RHEL_RELEASE_VERSION(7,0))) > > >+ > > > > > > #ifdef NETIF_F_RXHASH > > > #define PKT_HASH_TYPE_L3 0 > > > static inline void > > > > > >@@ -3851,6 +3854,8 @@ skb_set_hash(struct sk_buff *skb, __u32 hash= , > > >__always_unused int type)> > > > > =09skb->rxhash =3D hash; > > >=20 > > > } > > > #endif /* NETIF_F_RXHASH */ > > > > > >+#endif /* < RHEL7 */ > > >+ > > > > > > #endif /* < 3.14.0 */ > > >=20 > > > #endif /* _KCOMPAT_H_ */ > > > > > >-- > > >1.9.1 --=20 Thomas