From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62398A0544; Tue, 11 Oct 2022 00:45:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08ED140DFD; Tue, 11 Oct 2022 00:45:01 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 8AB1840146 for <dev@dpdk.org>; Tue, 11 Oct 2022 00:44:59 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 3A1165C0153; Mon, 10 Oct 2022 18:44:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 10 Oct 2022 18:44:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665441899; x= 1665528299; bh=xDRFFiCDlr7mYFu/fpRzZFTrOT0UzgSaIuw7w/WNhWw=; b=M DzeRxtwSCEk7m6k9qas7SFPCoOldVBg9VEdvswdWLoTI0ukipB/O4+OtEtCLP/H3 U4yUfumub0kjqKYpuUO5Ktu8eP4QFcbLXBR6BMRY5MoxMmILMQI0WeuFd4gLCXuM icx8XGa6OB80LzNKzNOElwQvFrMN+Cn5mUKIpxrSoC2rLmdLNJkR5zd8urC5nPHw Ls1AUAxTBxqc50Lz25ZaxBWQl/chAO4C7HA9X9QR0QzaP1Ehcq5XJzvI9H18zcKR 4eF7pBhQqEUcfQCWM9nqZhG1bOaeZHx7QtpTECPtkgMEAeIC3s0qAMo+Is1K8AVM /QnbJCa0YTpAgthShMXoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665441899; x= 1665528299; bh=xDRFFiCDlr7mYFu/fpRzZFTrOT0UzgSaIuw7w/WNhWw=; b=b 7+0ZTf6ab3QigISKphy0kiQv0t036BMSyWisevq/nWDt5pjUaEjZigNPLb1bKYGQ nwSI3n1zan12RJUUMkc2q/FodXuiTATzsfmsFxIvNeB6DOJcrwxAhhV6RxihXNal N1xkoAMQYp0AMD7UKQ4p2N3guw5Pqd/dU6NiKwyfwLKPP8BHVa6cW3Q+tVw6DdCL DEYdHwyClLYXdNG/seutjsSfXH2aI/UlVUQNSNBlMuuKTW4uYIjiptRi9wJogFTd NCwSCxIlhAP25WMpMztGERs3CUbvydOlDStXbkpotTTFaj480438nkCQXJkOuv2+ 7BYyothFxgWqYLsVPJMtw== X-ME-Sender: <xms:a6BEY3orYln0f41ph7LSwbtNtyhRH1_dqECtAn1SSxj-409nX02g-g> <xme:a6BEYxo7SmrxE3EaAU19uXTtkjKaSrJI00tkiczc0CEys32SNxvEZq1vhlDBVLrW3 f8o1YvV09TTY3T87w> X-ME-Received: <xmr:a6BEY0PeDPJkL4jGVGj-EF8bl8DU39P6MTzoSEiuT8SNjErMdroVffstA9kFi6T5YyR1cWrDYhyK0yG-aVR8BIsCxg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejhedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:a6BEY65A0uNhdwIvLB6Zsmr7Dfzi-xdHLx0FCwPTN4J15SSlpOOMQw> <xmx:a6BEY26iTaeOE7GHZWY0KCcz2D2kOVfEKlOh_11mNfZ2JS2d9PU_Jg> <xmx:a6BEYyiZS57mtTa_-Jcq1N_eH-r5Ea2sm3aupFJY2x4MJzlM26KVfQ> <xmx:a6BEYx1qt-egGoSHfAzGxBI7JiSPmLTVydRsmdJvYsALR-FPXvUTYQ> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Oct 2022 18:44:58 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Robin Jarry <rjarry@redhat.com> Cc: dev@dpdk.org, Robin Jarry <rjarry@redhat.com>, Ferruh Yigit <ferruh.yigit@amd.com>, Olivier Matz <olivier.matz@6wind.com>, Bruce Richardson <bruce.richardson@intel.com> Subject: Re: [PATCH v7] usertools: rewrite pmdinfo Date: Tue, 11 Oct 2022 00:44:56 +0200 Message-ID: <2415152.uoxibFcf9D@thomas> In-Reply-To: <20221004192909.457503-1-rjarry@redhat.com> References: <20220913105811.84384-1-robin@jarry.cc> <20221004192909.457503-1-rjarry@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 04/10/2022 21:29, Robin Jarry: > dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag > merely prints multiple independent JSON lines which cannot be fed > directly to any JSON parser. Moreover, the script complexity is rather > high for such a simple task: extracting PMD_INFO_STRING from .rodata ELF > sections. Rewrite it so that it can produce valid JSON. > > Remove the PCI database parsing for PCI-ID to Vendor-Device names > conversion. This should be done by external scripts (if really needed). > > The script passes flake8, black, isort and pylint checks. > > I have tested this with a matrix of python/pyelftools versions: > > pyelftools > 0.22 0.23 0.24 0.25 0.26 0.27 0.28 0.29 > 3.6 ok ok ok ok ok ok ok ok > 3.7 ok ok ok ok ok ok ok ok > Python 3.8 ok ok ok ok ok ok ok ok > 3.9 ok ok ok ok ok *ok ok ok > 3.10 fail fail fail fail ok ok ok ok > > * Also tested on FreeBSD > > All failures with python 3.10 are related to the same issue: > > File "elftools/construct/lib/container.py", line 5, in <module> > from collections import MutableMapping > ImportError: cannot import name 'MutableMapping' from 'collections' > > Python 3.10 support is only available since pyelftools 0.26. The script > will only work with Python 3.6 and later. > > Update the minimal system requirements, docs and release notes. > > Signed-off-by: Robin Jarry <rjarry@redhat.com> > Tested-by: Ferruh Yigit <ferruh.yigit@amd.com> > Tested-by: Olivier Matz <olivier.matz@6wind.com> > Acked-by: Bruce Richardson <bruce.richardson@intel.com> Applied, thanks.