From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 02D001B83B for ; Tue, 3 Apr 2018 18:44:20 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 77A8121910; Tue, 3 Apr 2018 12:44:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 03 Apr 2018 12:44:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=mPMIxHnQI7DX0j5stuxkOy0HU/ xCcWyFY7CVTs7FK4c=; b=N4IXvCkV0Xe1+kcJAV9euyCY49v4eG7hyCg+gkNqud NdnPYjUmsbkYu5KrYhCVYMQe6GroKPmtZUx8zfpzH7ocXS49uIcXX41/r3IrdqDT MoyQCgmCXpGyyAkCzWJROdzrR5e2NexXSr/NWBSVvPFJYaJ99qJhbZFmu+KuU61N o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=mPMIxH nQI7DX0j5stuxkOy0HU/xCcWyFY7CVTs7FK4c=; b=M+Zg0gXakPBWS8ddUT1F07 g7EK8C+0Cp7hyRQja/xJ3RVDifxm7AHyzRuhmNNTohOdCVrljJ+EfBGeSmK5mnwX 7k3SrSWenp990u98F+u9RNRZR3BatCdkgHyzrRkwYB5LRmFF8MTgeozlpKsee8lC dA0MYGI0ErKH8s9C20/v1mr46F5P9igRPcVWsluoOi5y/x5J3Vxa75cOvOLle5q2 M8IzoBKCb/hYNnTaQ9GHTYC97DJB3kuSfAByTZADgYGj01nTcTz/0tBsdTj37l+y 2KkSBoWBTRSST+9J9X9RLzhXMGOJjmleOTdDqxsD9w6xH9P4OlYQpKHukQMvWS3w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 86DE0E509C; Tue, 3 Apr 2018 12:44:19 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , "Wiles, Keith" Cc: "Mcnamara, John" , "Kovacevic, Marko" , "dev@dpdk.org" , "Richardson, Bruce" Date: Tue, 03 Apr 2018 18:43:15 +0200 Message-ID: <24175442.FuofMSqENj@xps> In-Reply-To: References: <20180403092859.71589-1-ferruh.yigit@intel.com> <4D4592F2-7C34-489E-BBAD-A3E8422FD468@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 16:44:21 -0000 03/04/2018 15:29, Ferruh Yigit: > On 4/3/2018 2:17 PM, Wiles, Keith wrote: > >> On Apr 3, 2018, at 4:28 AM, Ferruh Yigit wrot= e: > >> > >> Library folder name and output library name are same except a few flaws > >> including librte_ether. > >> > >> This library is network device abstraction layer, the name "ethdev" fi= ts > >> better than "ether", and library & header files already named as ethde= v. > >> > >> Also there is a rte_ether.h in the net library which can cause confusi= on. > >> > >> Signed-off-by: Ferruh Yigit > >> --- > >> Not sure if the we are ready for this change J > >> > >> This is one the issues that the hassle of the change doesn't worth the > >> benefit and you may prefer to live with the flaw. > >> > >> Also a concern is this breaks the git history. > >=20 > > I believe as long as you used =E2=80=98git mv=E2=80=99 the git history = should not be broken, correct? I think "git mv" does nothing special. Git tracks the content, so it is the same as using "mv + git add + git rm". > I think this will help in some conflict resolving or git blame, but if yo= u check > the history directly with path, it won't show the past: >=20 > "git log --oneline lib/librte_ethdev/": Will start from this commit You can use --follow. Unfortunately, it does not work well with gitk. You need to use a trick like https://stackoverflow.com/a/37375502 But there is no good solution when tracking a directory, like ethdev, which had a file split recently, and a directory rename.