From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 85330591E for ; Mon, 27 Feb 2017 14:49:00 +0100 (CET) Received: by mail-wr0-f179.google.com with SMTP id u108so22651929wrb.3 for ; Mon, 27 Feb 2017 05:49:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=MUmMl6kwcuhlItZPgz9jSdFhlRpMFt5jmD1VHZU58CQ=; b=TYPqOfZM6HCSKp0haCxfOwZlfzkrG9WQgQouUOu6pHDvI4l28hECDSSlhs/sbqi0+F MV6Wfd/VYwvqxVIQceOW9Bprgq3IVp2YsMTTr+uPnyKs2hPNbvARh78IjqZSMncUokEX hEB6JpohR4mydG0jKEknybed4Y7DvK//Y6waHwKSM26MVOxqMzlUqWLcastLJOlTwa6B ELLot0Sjj7JgZ/us8b/+e+pSbRp3Zv1LjqAP7/lrN6Hiv3kOJZjIV+GUj+GlailSbuDV xcK8KeE4W1/Co7rS5IWEyRnTCzcYTjLKaq0tDAWM/luRWLF04BYDoYAw4GEXowqbT+Fn b3qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=MUmMl6kwcuhlItZPgz9jSdFhlRpMFt5jmD1VHZU58CQ=; b=C6hXjXOGKvwIl8pWKnfPZxX7/HN77Y/Bh516tBk9G0BC2dccg3oDWs1aWWZo1RBW5o jB9bNIj8/2t6/ResggZx4zHIpktY5n19YQfScyFCxDXA/OIwKqwSYt45C6wp375KVvPl apIM9bTfFLBB2lmq9/U5c1t2JGnSwXjXkshML0K5WIp8566pYCMnSjcIh9Y9ws9aWIuD 0aT5XjMcbrYnpc3jf8ukzWN9+xNdowdys8WpZQg4IoyUDrixrMVbCYesWyONBf6sm5Oq GVS2X2MiYmbMCYIaiNvr+xJM60IccUdEWcXK82wbe3fF4DsIY5yo/Y5jfOiqTWcjTIWB 6EmQ== X-Gm-Message-State: AMke39m8vaCK4aVzbwIdhhcvCoL27+ihfhlgKh26h88cVie83SEaKKt8A7/Zh0rRhd4qfSll X-Received: by 10.223.154.149 with SMTP id a21mr8899267wrc.145.1488203340026; Mon, 27 Feb 2017 05:49:00 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w17sm22448093wra.28.2017.02.27.05.48.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Feb 2017 05:48:59 -0800 (PST) From: Thomas Monjalon To: Billy McFall Cc: wenzhuo.lu@intel.com, olivier.matz@6wind.com, dev@dpdk.org Date: Mon, 27 Feb 2017 14:48:58 +0100 Message-ID: <2417966.3G0haXHz4n@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170127183800.27466-2-bmcfall@redhat.com> References: <20170123211340.22570-1-bmcfall@redhat.com> <20170127183800.27466-1-bmcfall@redhat.com> <20170127183800.27466-2-bmcfall@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 13:49:00 -0000 2017-01-27 13:37, Billy McFall: > --- a/doc/guides/nics/features/default.ini > +++ b/doc/guides/nics/features/default.ini > @@ -55,6 +55,7 @@ FW version = > EEPROM dump = > Registers dump = > Multiprocess aware = > +Free TX ring buffers = I'm afraid this wording will be confusing, because every drivers free their buffers :) What about "Free Tx mbuf on demand" ? And please, move this line upper, just after "Rx interrupt". We also need to carefully review the doc you provided (thanks). First quick comment, please wrap lines shorter in the doc. About the function prototype, I've seen a double space :) I think you could use rte_errno (while keeping negative return codes).