DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: hemant.agrawal@nxp.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix kernel modules build dependency
Date: Thu, 29 Mar 2018 18:43:21 +0200	[thread overview]
Message-ID: <2419180.MvykWTCLKm@xps> (raw)
In-Reply-To: <1b87dc99-c4a5-21d0-9d78-3ea024f6a0c4@intel.com>

29/03/2018 18:38, Ferruh Yigit:
> On 3/29/2018 5:32 PM, Thomas Monjalon wrote:
> > 29/03/2018 17:48, Ferruh Yigit:
> >> On 3/29/2018 4:39 PM, Thomas Monjalon wrote:
> >>> Some kernel modules may need some header files to be "installed"
> >>> in the build directory.
> >>>
> >>> When running multiple threads of make, kernel modules can try to
> >>> be compiled before the lib headers are ready:
> >>> 	make -j3
> >>> 	kernel/linux/kni/kni_misc.c:19:37: fatal error:
> >>> 		exec-env/rte_kni_common.h: No such file or directory
> >>
> >> Is there a reason to keep header in eal when module itself moved into kernel?
> > 
> > It seems you missed my comment below:
> > 
> > On a related note, this header file
> >         lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
> > could be moved to lib/librte_kni/
> > Opinion?
> 
> Ahh, yes we are saying same thing.
> But not sure if it should go under lib/librte_kni/ or kernel/linux/kni/?
> I lean to kernel/linux/kni/.

Why in kernel/?

Logically, kernel/ depends on lib/ but not the reverse.

And regarding the licensing, we avoid BSD files in Linux modules.

  reply	other threads:[~2018-03-29 16:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 15:39 Thomas Monjalon
2018-03-29 15:48 ` Ferruh Yigit
2018-03-29 16:32   ` Thomas Monjalon
2018-03-29 16:38     ` Ferruh Yigit
2018-03-29 16:43       ` Thomas Monjalon [this message]
2018-03-29 16:50         ` Ferruh Yigit
2018-03-29 17:01           ` Thomas Monjalon
2018-03-29 18:12             ` Hemant Agrawal
2018-03-29 18:28               ` Ferruh Yigit
2018-03-29 18:21             ` Ferruh Yigit
2018-03-29 18:43               ` Ferruh Yigit
2018-03-30  8:32                 ` Thomas Monjalon
2018-03-30 10:15                   ` Ferruh Yigit
2018-03-30 11:03                     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2419180.MvykWTCLKm@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).