From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 92D272BC7 for ; Thu, 29 Mar 2018 18:43:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8449320DE3; Thu, 29 Mar 2018 12:43:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 29 Mar 2018 12:43:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=299T7Fd+BxyJ5z4aXYKYDJjf3O 3wRsm6jS8cZTR5SnU=; b=NtGR8jX7/+fJ3YetMMjsYYbQJ4TsfFEsvxqk+TaQiv zYLobM79Fl/YTfY5uQno5KkpC4QZ54Yjx1G/Rsg0o/xB9xYEqq9lAeYFRmkbbS+Y F+kJlJn/8QGhkQUmzyBLRiT+zs2l8CIfTCpWAMeP5PDUle53JP7KyrY7veEFN45O U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=299T7F d+BxyJ5z4aXYKYDJjf3O3wRsm6jS8cZTR5SnU=; b=i1fGdOxsth9J+z7ODjZSKD 6ywEp0jdDJlIpNfW3MoMNWQ2hzm8XPzjA1rvL+lSsW5NuKMQu3ot0qdJz7X5zqKh Im+qXWMfjSSiq5QdK9nv99Gz3Qk9BXojlK/Y4+GcxstrBG9x9JdDKLpPy+awcG0v /C1YThKyr7x0RlFzLbamXMko5UivVjVraQjXk8Ajb3+xFvxOhwulk/m/CmXq1V/V 3+65Zt/Oiwp8TMOxoSwvdU2duQQ+GBoPYNE1yDbQmaWUOgzaBKkTCkusKJlU/dme mYcv3RhzJ6UCfVgtyrgxESoNSX/CwO3dCRa/XW+c5VsABlU5T2bqDteMjj7lUyeg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D771110257; Thu, 29 Mar 2018 12:43:37 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: hemant.agrawal@nxp.com, dev@dpdk.org Date: Thu, 29 Mar 2018 18:43:21 +0200 Message-ID: <2419180.MvykWTCLKm@xps> In-Reply-To: <1b87dc99-c4a5-21d0-9d78-3ea024f6a0c4@intel.com> References: <20180329153931.26351-1-thomas@monjalon.net> <1556410.U3gqVypkhP@xps> <1b87dc99-c4a5-21d0-9d78-3ea024f6a0c4@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: fix kernel modules build dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 16:43:39 -0000 29/03/2018 18:38, Ferruh Yigit: > On 3/29/2018 5:32 PM, Thomas Monjalon wrote: > > 29/03/2018 17:48, Ferruh Yigit: > >> On 3/29/2018 4:39 PM, Thomas Monjalon wrote: > >>> Some kernel modules may need some header files to be "installed" > >>> in the build directory. > >>> > >>> When running multiple threads of make, kernel modules can try to > >>> be compiled before the lib headers are ready: > >>> make -j3 > >>> kernel/linux/kni/kni_misc.c:19:37: fatal error: > >>> exec-env/rte_kni_common.h: No such file or directory > >> > >> Is there a reason to keep header in eal when module itself moved into kernel? > > > > It seems you missed my comment below: > > > > On a related note, this header file > > lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > > could be moved to lib/librte_kni/ > > Opinion? > > Ahh, yes we are saying same thing. > But not sure if it should go under lib/librte_kni/ or kernel/linux/kni/? > I lean to kernel/linux/kni/. Why in kernel/? Logically, kernel/ depends on lib/ but not the reverse. And regarding the licensing, we avoid BSD files in Linux modules.