From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 6561F2B9C for ; Fri, 1 Apr 2016 15:58:06 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id f198so27240623wme.0 for ; Fri, 01 Apr 2016 06:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=dn2aS/F1JKhpOYalLfeB8sB8JFhZpxfdWeNmi9koiZw=; b=JX51EfAfjeQeejjo+nXUN3tsVeKMcK5XyR7KFH++Apo41Vi2h7xSDyut5ivRoDddzy 66JDPLemhJSj41Q8JmfWFQK/XMF98vvENQMs6BcwpH0W4d+X5vWP+SI1Gqk2Y/ucn+Y3 U8jZXbTSJXDwbr448Cd08hoXs9tmjP7KxJianaojE+sniRAwGBm6dsVJ7JDbU0yxBayc Qwf2QThMt4v1XHz3cevW/ceZBBGSxXpdJm6fRBoTduXLt6Z4QMx5Ak2ZkfqepDUa/bcp Lk3ESfZqsZ6sDIEIduT4+RS4W2gb/1MLjjKZolXgVQ98zLF7CW6Fl9kRQs+F82phwFhg k7aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=dn2aS/F1JKhpOYalLfeB8sB8JFhZpxfdWeNmi9koiZw=; b=Qt3PswH/pfy7MoKi7kMBqhR4HOL0c1h05IZi+jrNovhjXWPYbImO2LY9z+Gwj9BPBO SHYeMa54l50R2K/6lp7dwJ/wcPVthVsUqIgysz7MPij46uf1ZVGMxwjt8ZmfSmmcFvsW Gybr1VLTHFtMgotOLbzAVgVgq6BPnsTRaKZ33VB1rIyO0k58lter7BYEpGSORCRBx0IK jx9PggAZY7PDsREQRiz2/hkkCAs89RpDUCaodjuLffp0iRxjRU/t/lNZIU22UxbGMYJ9 0ZwJYT06hrw7/RSL7pZX3t1uh/IFMTE04m5wSuR0C+Q6kl/s9h0TxlTPX6IkXsMo04hH oFCg== X-Gm-Message-State: AD7BkJJY/r4fqcCuIHIrWpDWVQYn+oQrzW8+8lvDDYbc834G1FaL0fG9co9fED4wMsQsZ6TX X-Received: by 10.28.222.84 with SMTP id v81mr4316633wmg.42.1459519086241; Fri, 01 Apr 2016 06:58:06 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id 192sm14742018wmw.0.2016.04.01.06.58.05 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 01 Apr 2016 06:58:05 -0700 (PDT) From: Thomas Monjalon To: Fan Zhang Cc: dev@dpdk.org Date: Fri, 01 Apr 2016 15:56:10 +0200 Message-ID: <2420426.ojDceOkhvu@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1459518117-23944-4-git-send-email-roy.fan.zhang@intel.com> References: <1459518117-23944-1-git-send-email-roy.fan.zhang@intel.com> <1459518117-23944-4-git-send-email-roy.fan.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/3] port: code clean-up X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 13:58:06 -0000 2016-04-01 14:41, Fan Zhang: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -92,9 +92,7 @@ endif > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n) > _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse > endif > -ifeq ($(CONFIG_RTE_NEXT_ABI),y) > _LDLIBS-$(CONFIG_RTE_PORT_PCAP) += -lpcap > -endif Why removing NEXT_ABI here? The pcap port cannot work without it because of +#ifdef RTE_NEXT_ABI + + /** The full path of the pcap file to read packets from */ + char *file_name; + /** The number of bytes to be read from each packet in the + * pcap file. If this value is 0, the whole packet is read; + * if it is bigger than packet size, the generated packets + * will contain the whole packet */ + uint32_t n_bytes_per_pkt; + +#endif