DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Harris, James R" <james.r.harris@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: [dpdk-dev] Questions on DPDK pkg-config
Date: Wed, 23 Sep 2020 18:21:16 +0000	[thread overview]
Message-ID: <2420F93D-75BC-4983-9529-1A3F1DE08955@intel.com> (raw)

Hi,

SPDK would like to use DPDK’s pkg-config files rather than rolling our own linker arguments.  I’m running into a couple of issues – one looks like a bug, the other is not as clear.

First is the use of --as-needed (https://github.com/DPDK/dpdk/commit/b98447077b0609750c10b84b7b2e7be0c8504fad).  We have run into problems with this in the past, specifically related to the rte_mempool_ring MEMPOOL_REGISTER_OPS constructor functions.  --as-needed results in similar behavior to omitting --whole-archive when using static libraries – meaning the constructor function doesn’t get called and we cannot create any mempools since there are no registered mempool_ops.  I think this would also affect other uses of constructor functions within DPDK when using pkg-config, but this rte_mempool_ring one is the only that would impact SPDK so it’s the only one I’ve checked.

Second is that rte_bus_pci is not included in the pkg-config output.  SPDK relies on rte_bus_pci since we have our own DPDK drivers for things like nvme, virtio-blk and virtio-scsi and need access to rte_pci_read_config, rte_pci_write_config and rte_pci_register.  Perhaps we could add bus_pci to the dpdk_libraries in lib/meson.build?

Any help would be appreciated.

Thanks,

-Jim

             reply	other threads:[~2020-09-23 18:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 18:21 Harris, James R [this message]
2020-09-24  9:26 ` Bruce Richardson
2020-09-24 14:34   ` Harris, James R
2020-09-24 14:43     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2420F93D-75BC-4983-9529-1A3F1DE08955@intel.com \
    --to=james.r.harris@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).