From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A029C91 for ; Wed, 27 Feb 2019 09:33:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 38C8221F03; Wed, 27 Feb 2019 03:33:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 27 Feb 2019 03:33:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=WgSqlhsnMgFUuGeRNED0/DKSLIzcBBDRmTUxFKNpn10=; b=VublasjW5SRl PWPSciokcuASRvUjGzMQSoBNAE3Z3IIo5cTk3rcxQgGPn+mOJhnu09z3Mu8tzQFV 5ZgrTVCTfui0CE8UYj3OyUVdZqJXZPk9nB9Zhnt52UB3k6Ndk9vW0HdDkeMZSjDG T3MCTLSBJA4Bezzp9aLyfKMcm2S43yw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=WgSqlhsnMgFUuGeRNED0/DKSLIzcBBDRmTUxFKNpn 10=; b=H3k6JdCiK0TFWjTFDu66idHtfQweECGvZUH38trwVnwW+vlIN61HnLg1v zyDmKQ5VvIgzNu7B2ILsiUojE0xSS4Ncmy8b/nsOqG+sxg26NKQDz6jGChT/MgPz jQU/y53NHW329ZapnpD7YuULVGOu13eWvrlOxSR/PJnKJYz2ugsfzjifIOwxs2rJ 6zYCmgXaK7brKFoURlWz0UFp8JgLiA8qfAAyMXM7J9SzmJPfvF3MOhvyQa5BYakU 5QfZ98SAldtMq6sgQ5sZCMJLtDGTWD0S5IdOMPEmdTwIfwbLl6qAzYLn5LpbTGIA EKGTGoP7CU/W2vC355i1NZRF83tbg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvddtgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedriedrudegledruddugeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 1F2F7E4484; Wed, 27 Feb 2019 03:33:14 -0500 (EST) From: Thomas Monjalon To: Luca Boccassi Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Wed, 27 Feb 2019 09:33:12 +0100 Message-ID: <2422048.eyOlUYzsqs@xps> In-Reply-To: References: <20190103175725.5836-1-bluca@debian.org> <20190226174637.27452-6-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 08:33:15 -0000 26/02/2019 18:49, Luca Boccassi: > On Tue, 2019-02-26 at 17:46 +0000, luca.boccassi@gmail.com wrote: > > From: Luca Boccassi > > > > pcap has historically shipped a custom pcap-config binary tool which > > does the job of pkg-config. It was never compatible with cross > > compilation. > > Meson uses it when using dependency(), which then means cross > > compilation fails. > > Set pcap-config to empty in the meson cross compilation files so > > that Meson will not use it, and add a fallback in case > > dependency() fails. > > libpcap 1.9.0 finally ships a pkg-config file so everything will > > work out of the box in the future. > > > > Signed-off-by: Luca Boccassi > > --- > > v8: added back pcap change separately. Tested with bootlin > > cross-compilation toolchain, everything seems to work. > > I had some time to invest so I added back this change, in a way that > works with cross compilation too. Given the series wasn't merged yet > and there was a conflict I've done a v8 rather than a single separate > patch, but it's independent from the rest. > > More testing is of course welcome! I still see the same error when cross-compiling: /usr/include/stdint.h:109: error: "__INT64_C" redefined