From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id F32552931 for ; Wed, 5 Oct 2016 18:29:24 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id k125so276980283wma.1 for ; Wed, 05 Oct 2016 09:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=f/PJf/5mw4Wihw8VvYxN+XpqO5B85xweX6T1Euh+4Kg=; b=tGl335uHrtEfLO2IYw1rPvVzJ8C0g2ScXB1UBUmL696HbAgP37bRsPeHLatcyZANH+ Kn/VPRT8fQPEelkFXP0D2rlCmCZmm1ZqVBIEAUuzedw61TCiOnnhV1A8rdtkEDakNbmz dIAhruTieRgNDS7GuhO2n3QETZFal3ASnKnO7KK+YGLmALjDB+uK/E3ihxzzZZg8guiO O2M2tlN6tsxIkMkA9E90RDoNeo/0bPal2x6IBFNJjAlUyuvvWMPZ5ITwyRxzGIDdQs7U lbxFn3YEGsr8w8w0L3aYexG9KLdTLsaqbx+OKX6s/24fS3GaiDDer7ojAhNMQAUi4LO5 TmKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=f/PJf/5mw4Wihw8VvYxN+XpqO5B85xweX6T1Euh+4Kg=; b=lUinfLyRQ4QZDE2WNdhSQByJYC6E6kt8QMvOhHfgok51y7Ej4YQV6Y3zjE+eqW86vr gP4BANUiZXM8ApejBznOEdRZNQZJzydNmOeBa1Lg7l0y84KgUQgLxyEy7a7o6TzTcK1e mxfWo+Cv1KrYgC71qJ03JoHdzsIv/GF9HmAfFsx6TNntXCd2YevT0Jw5QoChpUj4GtgP evc9driBtfMpNrhISHtP9WyehaM+FxW9HhAhFUfyfe2uFt2sG4624wc9ku4CQg1G6zlv 6z5R1NWj9gR4j5owfaVUHjVLLlTugB3f6+KkfMpj5EeusqNjBb/1b9OeZnlf1XG66Vid 3fpw== X-Gm-Message-State: AA6/9RnSbKUJrqIAAFHWPk8/iXzrhOUMzVuAUVqlTLLvWYNZZsSn7d/TL4GbEiXCH8v3yBfn X-Received: by 10.194.94.168 with SMTP id dd8mr8218522wjb.96.1475684963526; Wed, 05 Oct 2016 09:29:23 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id jt8sm5429437wjc.33.2016.10.05.09.29.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Oct 2016 09:29:22 -0700 (PDT) From: Thomas Monjalon To: "Mody, Rasesh" Cc: Ferruh Yigit , Rasesh Mody , dev@dpdk.org, "Dept-EngDPDKDev@qlogic.com" , Bruce Richardson Date: Wed, 05 Oct 2016 18:29:20 +0200 Message-ID: <2423952.d1lHHhMD9K@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1475219169-8774-1-git-send-email-rasesh.mody@qlogic.com> <1ac6d74c-cc78-4efd-275c-9645952fb8a0@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 04/22] qede/base: update base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 16:29:25 -0000 2016-09-30 18:40, Mody, Rasesh: > > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > > Thank you for the update, base driver patch update now reduced from > > "14653 insertions(+), 8536 deletions(-)" to > > "10857 insertions(+), 4853 deletions(-)" > > > > But this is still to big for reviewing, specially there are some low hanging fruits > > for cleanup, like big chunk of comment updates or whitespace updates or > > non base driver codes in the patch. > > > > If the expectation is that somebody non maintainer review the code, > > understand it and highlight any possible defects, I believe this patch is too big > > and needs to be split more into logical pieces, but since this is a driver code > > and a little special, and it may not be possible to completely understand the > > code without knowing underlying hardware, I am not sure how to proceed > > and adding Bruce and Thomas to cc for guidance. As you said it makes contribution really hard. So it is missing the point of sharing its source code in Open Source. > This 8.10.x.x base driver is a common code shared by multiple drivers. It has gone through extensive testing. > We have split the base driver patch into smaller logical patches. It would be difficult to split this patch further. Please check how Intel updates its base drivers and try harder. We all know it requires some time, but it provides a valuable knowledge base. Thanks