From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A2A47A568; Fri, 12 Jan 2018 15:42:50 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2EDD320AF5; Fri, 12 Jan 2018 09:42:49 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 12 Jan 2018 09:42:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Z/LturS4ce25SnnJnPjfnxwAQM pIkZHW22kTJF7UqeA=; b=X9l3iKDojZTyd3SG5iQNLUCg24HOsBsAdgrc+u6rS9 hRtEcrIey5H0LaZkNYMSWoAlrn7yNTWkNUYDbPquZM1BDbv2igpVmA1HHXr850QU rrudGUw2uDeesZyidGIUpo1qI6Wo4emklA5N2cLtYZi7eK0Esb185LhW7k1uP3CZ I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Z/Ltur S4ce25SnnJnPjfnxwAQMpIkZHW22kTJF7UqeA=; b=I622oVRAw6ftDGS+w79Nn9 cdtalzMf8gioYXjhGzg4Ap8HF37zfyW9Ulsm694B3/0XZkfIXgljcuthVTQ1HAqP JqFeejurtCs1lyrf3LbqwyeKyh/HQHXf/mnr+gXqxVcrUC1cK2ZMZUDSsLCdSOiB JNbnMWbsT8qnkEVqUH/SOw+AkV5McxxZ0iB4ptQMWt5S9INKGwlFGkjhQm1+2dtH hWopJyM5x0k2/3rHCMlrx62r5o2TZgCmq8tB9+1FYPnQcrh/NjW/WCp0jc7wxCVG PUvrCpbEpr7diOplSzAk5XJna7yBE8TMImWS1JFQt9X/1Kvyuyw+8Likmrim12gg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DE27B247FC; Fri, 12 Jan 2018 09:42:48 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, stable@dpdk.org Date: Fri, 12 Jan 2018 15:42:19 +0100 Message-ID: <2424466.Pz8JVrVW5I@xps> In-Reply-To: <39635342ba1c29bc96bee904e6b888b058f0a5ca.1513865781.git.anatoly.burakov@intel.com> References: <39635342ba1c29bc96bee904e6b888b058f0a5ca.1513865781.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: protect malloc stats with lock X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 14:42:50 -0000 21/12/2017 18:32, Anatoly Burakov: > When we're gathering statistics, we are traversing the freelist, > which may change under our feet in multithreaded scenario. This > is verified by occasional segfaults when running malloc autotest > on a machine with big amount of cores. > > This patch protects malloc heap stats call with a lock. It changes > its definition in the process due to locking invalidating the > const-ness, but this isn't a public API, so that's OK. > > Cc: stable@dpdk.org > Signed-off-by: Anatoly Burakov Applied, thanks