From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id BBE08C8C6 for ; Fri, 26 Jun 2015 15:01:23 +0200 (CEST) Received: by wicnd19 with SMTP id nd19so17085649wic.1 for ; Fri, 26 Jun 2015 06:01:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=0DFPFeBiHkEmWfhywomQNLVBNiL0dnNgjSGm7C7eAR8=; b=altqKMVjCuKija7/KqhIIzedv9Tfjtt3jZMmG48rG5RsGe/LaAdXYBJm64ATaA2jw0 JucT/hZYzwDhCtJhz5vaUXI8yiLAhEinosqLJ14w6+zUEb/UXqSunVQPFz7GwQTZAmLs kJ9tn+iD67axtooNp6QyuriZVdntsZnbUqbJ5SBvSnwzkX/WhhtUoKf3nbPjHJVXA4Zm m40kueIiuKwsdTzWEaWi5IX4G1xj3kAIlVKafvkU/tGN4KBml8JD9kvb4PRx+kpXtAJO V8xWSdplflK4Y7BVnuWQ5zdyf3nAvV6xZPvaHgI3WdxOuOyvnew5Tt05hhwCZJVFPVc8 om7g== X-Gm-Message-State: ALoCoQmGsrzfG9TL9CY0T7K55UuC9Z7AKnBOzlNE4PASzKrW3R82imf90GWXgLLDaHk3sxvXJ/ot X-Received: by 10.194.185.236 with SMTP id ff12mr3028615wjc.134.1435323683658; Fri, 26 Jun 2015 06:01:23 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fo13sm2161990wic.0.2015.06.26.06.01.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jun 2015 06:01:22 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Date: Fri, 26 Jun 2015 15:00:17 +0200 Message-ID: <2425730.LWzQFRnlUA@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1435242949-31520-3-git-send-email-nhorman@tuxdriver.com> References: <1435088014-18973-1-git-send-email-nhorman@tuxdriver.com> <1435242949-31520-1-git-send-email-nhorman@tuxdriver.com> <1435242949-31520-3-git-send-email-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCHv3 3/3] ABI: Add some documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2015 13:01:23 -0000 2015-06-25 10:35, Neil Horman: > v3) > * Fixed in tact -> intact > * Added docs to address static linking > * Removed duplicate documentation from release notes It seems you missed some of my previous comments. [...] > +* ``VERSION_SYMBOL(b, e, n)``: Creates a symbol version table entry binding > + unversioned symbol ``b`` to the internal function ``b_e``. Should a versioned symbol @DPDK_ > +* ``BASE_SYMBOL(b, e)``: Creates a symbol version table entry binding > + unversioned symbol ``b`` to the internal function ``b_e``. Please give a use case of BASE_SYMBOL. [...] > +The addition of the new block tells the linker that a new version node is > +available (DPDK_2.1), which contains the symbol rte_acl_create, and inherits the > +symbols from the DPDK_2.0 node. which contains the old version of the symbol rte_acl_create