From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 82B79A0526;
Tue, 10 Nov 2020 11:46:00 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 5F206F64;
Tue, 10 Nov 2020 11:45:59 +0100 (CET)
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com
[64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 02C21DED;
Tue, 10 Nov 2020 11:45:57 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.west.internal (Postfix) with ESMTP id 8A106E18;
Tue, 10 Nov 2020 05:45:54 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Tue, 10 Nov 2020 05:45:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
fejRt/PZr1xHu7m0Aa0xZGFqC4HgoIPKOa5BR1MR8XE=; b=Ae1nqoPTkv0EK/bN
DlX48iC/ZdPnrPLJgco13sQr2MawY4I1qHsya/4QBLFgVUiFy82jdwD8EuFDW5nY
1oUaEdtCI60KndxTu1UDf03edTYE4V49QAtweZZm63EC4CZSRFJiHJu2IV+XVt3m
Ngt5H+Nv5FU8zrcU97G0a2HYyNh7tFc8jmD+xBjsR6IB7SvvB0Qqj4oYQeUZSqWm
OM3y3H6mvthyxWm70FEPcKuzyVvUuL7KbLk4j3vR2hBTepOym5l/D+2kcL/9Sqrq
PY8MyLKtXCw7O1UZbYnPIbFzcs+T+qAYX+J5P9bkUa3qrFmeKVFsZk2TRzEGMnPk
fA6lEQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=fejRt/PZr1xHu7m0Aa0xZGFqC4HgoIPKOa5BR1MR8
XE=; b=QlqVaQ3obwaSGDBOLJ3pbxzIcSE+A1elEO8gkQQQK2gar5ZkaYnjx5cv7
nKLOq5PNICSsybLcSiu4O8nccaVLmb4iaDqTxk3o1n40ilT9paLGkTMwQDTPTgsr
/DdSrpxwKCE8+BOOxkZ4BZEn3hDII2QKN/mNB+mxS3z1u0c67g+TyOtVySD1Evgl
eZvPSolaUt1XgQ6nbqbqJkaKvDNvAmx9YeEN563WKzwzJ9ms6LW8zJMQzAQr1Zu+
XfHeVuDL/fFpOTalQqmqFDUUZ9Pi7MalzH1agYDJdVzTJc/rnVl1SVfi14CgurjD
8wao7ZPAia8wXm8USIb72ahnjy6fw==
X-ME-Sender: <xms:YW-qXwAUAvlCzrkPXu76-jP4FTTppHnujH4eWAXaN5WcA68VE3E1hg>
<xme:YW-qXyig0Ju6fGXsUzbRlr3vwPlUxRxDBSjkqbhJzA-T2swzFhgvnCBKsb8SbMEMw
TVN6z1gfGKiF9etQw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddujedgudelucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:YW-qXzl5-BMgyBaiKCeLfnJgwKWFBj6TLGXQe-9cEmNfaJ0tTpszPQ>
<xmx:YW-qX2w_JDEM9pHIK5qlYjtRAtgRmlubaZOGIr7PSPbQW7AdBUIvIw>
<xmx:YW-qX1TNPdkxZ-KlhjV-UHMw_0wQ5rO_-_ZfyL0wQ6JSBEYaYIh4hw>
<xmx:Ym-qX3ezMxTYsBjSMQE4f3K2TbWAdELZH1pVZatWuipMMx365v3wnA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id E5D3F328005D;
Tue, 10 Nov 2020 05:45:52 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com,
stable@dpdk.org, Luca Boccassi <bluca@debian.org>
Date: Tue, 10 Nov 2020 11:45:52 +0100
Message-ID: <2429206.vUhvlFYDAN@thomas>
In-Reply-To: <20201110101419.GB1641@bricha3-MOBL.ger.corp.intel.com>
References: <20201109210009.919129-1-thomas@monjalon.net>
<20201110101419.GB1641@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config
inheritance from env
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
10/11/2020 11:14, Bruce Richardson:
> On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote:
> > PKG_CONFIG_PATH is specific to each target, so it must be empty
> > before configuring each build from the file according to DPDK_TARGET.
> > Inheriting a default PKG_CONFIG_PATH for all targets does not make sense
> > and is prone to confusion.
> >
> > DPDK_MESON_OPTIONS might take a global initial value from environment
> > to customize a build test from the shell. Example:
> > DPDK_MESON_OPTIONS="b_lto=true"
> > Some target-specific options can be added in the configuration file:
> > DPDK_MESON_OPTIONS="$DPDK_MESON_OPTIONS kernel_dir=$MYKERNEL"
> >
> > Fixes: 272236741258 ("devtools: load target-specific compilation environment")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
>
> Patch looks fine, but I think the log (and comments in the code too,
> perhaps) should make it clear that the PKG_CONFIG_PATH can be set in the
> local config file, to make it available to the script.
OK, I'll look at improving the "doc".
We could also provide a template for the config file.