From: Thomas Monjalon <thomas@monjalon.net>
To: "Bruce Richardson" <bruce.richardson@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Cc: Chengwen Feng <fengchengwen@huawei.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
dev@dpdk.org, nd <nd@arm.com>,
ferruh.yigit@amd.com, Dongdong Liu <liudongdong3@huawei.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>
Subject: Re: [PATCH] net/hns3: support disable IOVA as PA mode
Date: Mon, 20 Feb 2023 16:30:20 +0100 [thread overview]
Message-ID: <24304924.kmuVQn2iE0@thomas> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8775F@smartserver.smartshare.dk>
20/02/2023 16:07, Morten Brørup:
> With the new viewing angle, the current define RTE_IOVA_AS_PA makes more sense to me now than before. So we should probably stick with it, rather than introduce something that might confuse developers who already have the same viewing angle.
>
> But it still seems counterintuitive to me that disabling some feature ("enable_iova_as_pa") is not supported throughout DPDK; the logic seems inverted. Apparently, it also makes it difficult to assign good titles to patches that support disabling such a feature. :-)
>
> <irony>
> On the positive side, since everything supports this "enable_iova_as_pa" feature, we don't need to add it to the PMD feature list. If the logic wasn't inverted like this, the PMD feature list should probably reflect which PMDs supported the "iova_as_va_only" compile time option. ;-)
> </irony>
That's a change I would like to do:
The Meson variable in the drivers should be "support_iova_as_va"
and would mean we can compile the driver when "enable_iova_as_pa" is false.
next prev parent reply other threads:[~2023-02-20 15:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 7:11 Chengwen Feng
2023-02-14 11:09 ` Dongdong Liu
2023-02-16 8:36 ` Ruifeng Wang
2023-02-20 7:44 ` Thomas Monjalon
2023-02-20 9:11 ` fengchengwen
2023-02-20 9:43 ` Morten Brørup
2023-02-20 10:16 ` Thomas Monjalon
2023-02-20 11:12 ` Morten Brørup
2023-02-20 11:52 ` Bruce Richardson
2023-02-20 12:04 ` Morten Brørup
2023-02-20 12:23 ` Bruce Richardson
2023-02-20 12:47 ` Morten Brørup
2023-02-20 14:12 ` Bruce Richardson
2023-02-20 15:07 ` Morten Brørup
2023-02-20 15:30 ` Thomas Monjalon [this message]
2023-02-20 15:35 ` Bruce Richardson
2023-02-20 15:40 ` Thomas Monjalon
2023-02-21 7:53 ` Morten Brørup
2023-02-20 9:00 ` [PATCH v2] net/hns3: support IOVA as VA Chengwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24304924.kmuVQn2iE0@thomas \
--to=thomas@monjalon.net \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=liudongdong3@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=nd@arm.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).