From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0633941CEC; Mon, 20 Feb 2023 16:30:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E91C643074; Mon, 20 Feb 2023 16:30:27 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id BEA8A40395 for ; Mon, 20 Feb 2023 16:30:26 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 2D59F3200D19; Mon, 20 Feb 2023 10:30:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 20 Feb 2023 10:30:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676907023; x= 1676993423; bh=OWYSbZsaoK/YwGeVYxEvHc1XV0Cd8J17tBzUHSYVCIs=; b=O +xnj3ygcVxW+1RUIBRuWeL2q+njDf9AQkm/pfQzoxGXGOsX0vvAhp6R2flce9gbT 4beevpsTn5Z3h58W7AD6rPVmD3ViiNVHARyyNhHGrlcVGaDEwSDmisKxasYfW8Fj ez7VnEIte4Tfku+wYUia3Kbdj6L3tSpt/MMwQTUgT6kcmlOsKbZ2cRl176IVhFpb frQh7LFPUoO5laeHMmW9x6AoZU7A4Xz/iPOUOej4HWdMynIIF1HmSAcLBCi8ZLgI Hf+vN6mWJmKYt8AThcPQULkUXA9mg6AJ5RaE3dKqC65MkURW6j0gLjgTC1bI5FH5 FpozCi4EGdP0eEnbFpQWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676907023; x= 1676993423; bh=OWYSbZsaoK/YwGeVYxEvHc1XV0Cd8J17tBzUHSYVCIs=; b=e l/wZuCvu5DVmP14NRuVt7+QNoHAXnpb7kpnBgrzSeMwtzVkXHcCBOxBu4JSMwIpf bCM6kwl6/xmIUUKvCxldKJX/jE2K6wfMkQRWj7ww+ShxnrVa92gBskYfWoA4nLP+ EfDG+eywUBi9P+X8tdbdeEBwhd6Qz5qm/pzg1L+X+UXrY4NLGjl4zZXMm/9rNQ+l 3TnduYBzG/SJlHOcpQS4khy+CdycEKpsPa2jMuTO6x6zWRJ9/yOxx/l30QBlCflN VrM4bsRpuLORr5VTEYYgwvknJ/llfSd9a/C3UPOvDjyJfftEKJWVmjbJaeTFvMch cHGLcgiXXrX/4FofMSoZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejhedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Feb 2023 10:30:21 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: Chengwen Feng , Ruifeng Wang , dev@dpdk.org, nd , ferruh.yigit@amd.com, Dongdong Liu , Yisen Zhuang Subject: Re: [PATCH] net/hns3: support disable IOVA as PA mode Date: Mon, 20 Feb 2023 16:30:20 +0100 Message-ID: <24304924.kmuVQn2iE0@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8775F@smartserver.smartshare.dk> References: <20230214071141.50155-1-fengchengwen@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35D8775F@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 20/02/2023 16:07, Morten Br=F8rup: > With the new viewing angle, the current define RTE_IOVA_AS_PA makes more = sense to me now than before. So we should probably stick with it, rather th= an introduce something that might confuse developers who already have the s= ame viewing angle. >=20 > But it still seems counterintuitive to me that disabling some feature ("e= nable_iova_as_pa") is not supported throughout DPDK; the logic seems invert= ed. Apparently, it also makes it difficult to assign good titles to patches= that support disabling such a feature. :-) >=20 > > On the positive side, since everything supports this "enable_iova_as_pa" = feature, we don't need to add it to the PMD feature list. If the logic wasn= 't inverted like this, the PMD feature list should probably reflect which P= MDs supported the "iova_as_va_only" compile time option. ;-) > That's a change I would like to do: The Meson variable in the drivers should be "support_iova_as_va" and would mean we can compile the driver when "enable_iova_as_pa" is false.