From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82682A034F; Wed, 28 Jul 2021 09:40:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17AFF40E64; Wed, 28 Jul 2021 09:40:58 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C47D740142 for ; Wed, 28 Jul 2021 09:40:55 +0200 (CEST) Received: from [192.168.100.116] (unknown [37.139.99.76]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id D5A227F50B; Wed, 28 Jul 2021 10:40:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru D5A227F50B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1627458055; bh=hyaOC9BBgGFgyGF4ZlmVl7lmGBeCrfbXktDGH1OBw2Q=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=DNul07leZs4fCP1OJ1qc4yingjJJk7V8iv6p2PuuHxPJgzMcL8Mg2O5CrzUErpRfG 6Rj/j23BOnA1H6olEl8eP3LcGZkDUcfPOEGxN8Q0oa+2ADI3lO+NIrt9AdYzGkq6ZL giz9RQK1llT4M0ZkjBlWBZ/VFLmMvSmq2EogN4eU= To: Xueming Li Cc: dev@dpdk.org, Viacheslav Ovsiienko , Thomas Monjalon , Ferruh Yigit References: <20210727034134.20556-1-xuemingl@nvidia.com> From: Andrew Rybchenko Message-ID: <24309185-57e8-9a21-6b3a-939c4d74f1e7@oktetlabs.ru> Date: Wed, 28 Jul 2021 10:40:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210727034134.20556-1-xuemingl@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/27/21 6:41 AM, Xueming Li wrote: > To align with other eth device queue configuration callbacks, change RX > and TX queue release callback API parameter from queue object to device > and queue index. > > Signed-off-by: Xueming Li In fact, there is no strong reasons to do it, but I think it is a nice cleanup to use (dev + queue index) on control path. Hopefully it will not result in any regressions.