DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Liu, Yu Y" <yu.y.liu@intel.com>
Cc: "Wang, Haiyue" <haiyue.wang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
	"Ye, Xiaolong" <xiaolong.ye@intel.com>,
	"Kinsella, Ray" <ray.kinsella@intel.com>,
	"Sun, Chenmin" <chenmin.sun@intel.com>,
	Slava Ovsiienko <viacheslavo@mellanox.com>,
	"Damjan Marion (damarion)" <damarion@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information
Date: Sat, 02 Nov 2019 19:31:23 +0100	[thread overview]
Message-ID: <2431604.fJrMVA34KA@xps> (raw)
In-Reply-To: <D9E7459352598649B9DF0563CBC90AEB778BC13A@SHSMSX101.ccr.corp.intel.com>

02/11/2019 07:55, Liu, Yu Y:
> Add Damjan from FD.io for awareness...
> 
> Hi Thomas,
> 
> Long time no see. Sorry I use outlook which is not friendly to community email.
> 
> >Anyway I will propose to replace this API in the next release.
> Will your plan be affected by API/ABI stable plan? 

The API is experimental, so it can be changed later.

> BTW, if you propose new change in next release, it will make DPDK consumer(FD.io) to change again.

Yes I agree it is not nice.

> So even if it is not affected to the API/ABI stable plan, do we still have time to get a solution for everyone in DPDK 19.11 with your contribution/acceleration?

Yes we have time.
But you insist on an API without any good justification.

> > I suspect a real hidden issue in Intel CPUs that you try to mitigate.
> Please be rest assured it is not the case. 
> This request is just from one FD.io project internal bug " tx/rx burst function is shown as nil" reported by Chenmin. 
> My understanding is DPDK behavior was taken as bug for someone in FD.io project and potentially will mislead other DPDK consumer. 
> Haiyue is working with Chenmin to address the issue and with your support it will be even better.
> 
> Your support will be highly appreciated!

I already said what I consider to be good: a simple string.
Of course I may be wrong, that's why I asked questions.
But half of the questions are just ignored.

If you want to progress, please reply to the questions asked by Slava in this thread.


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wang, Haiyue
> > From: Thomas Monjalon <thomas@monjalon.net>
> > 
> > Thank you for trying to address comments done late.
> > 
> > 31/10/2019 18:11, Haiyue Wang:
> > > --- a/lib/librte_ethdev/rte_ethdev.h
> > > +++ b/lib/librte_ethdev/rte_ethdev.h
> 
> 
> > > +#define RTE_ETH_BURST_ALTIVEC       (1ULL << 2)
> > > +#define RTE_ETH_BURST_NEON          (1ULL << 3)
> > > +#define RTE_ETH_BURST_SSE           (1ULL << 4)
> > > +#define RTE_ETH_BURST_AVX2          (1ULL << 5)
> > > +#define RTE_ETH_BURST_AVX512        (1ULL << 6)
> > 
> > Of course, I still believe that giving a special treatment to vector 
> > instructions is wrong.
> > You did not justify why it needs to be defined in bits instead of 
> > string. I am not asking again because anyway you don't really reply. I 
> > think you are executing an order you received and I don't want to 
> > blame you more.
> > I suspect a real hidden issue in Intel CPUs that you try to mitigate.
> > No need to reply to this comment.
> > Anyway I will propose to replace this API in the next release.
> 
> Never mind, if this design is truly ugly, drop it all now. I also prefer to do the best, that's why open source is amazing, thanks! ;-)




  parent reply	other threads:[~2019-11-02 18:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 17:11 [dpdk-dev] [PATCH v1 1/3] net/ice: remove the specific burst mode bit set Haiyue Wang
2019-10-31 17:11 ` [dpdk-dev] [PATCH v1 2/3] net/i40e: " Haiyue Wang
2019-10-31 17:11 ` [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information Haiyue Wang
2019-11-01 22:46   ` Thomas Monjalon
2019-11-02  5:29     ` Wang, Haiyue
2019-11-02  6:55       ` Liu, Yu Y
2019-11-02  8:38         ` Slava Ovsiienko
2019-11-02 19:21           ` Damjan Marion (damarion)
2019-11-03  7:50             ` Slava Ovsiienko
2019-11-05 15:12               ` Ferruh Yigit
2019-11-05 15:54                 ` Stephen Hemminger
2019-11-03 20:46             ` Ray Kinsella
2019-11-03  2:34           ` Wang, Haiyue
2019-11-03  3:03             ` Wang, Haiyue
2019-11-03  8:59             ` Slava Ovsiienko
2019-11-03 11:38               ` Wang, Haiyue
2019-11-03 19:31                 ` Slava Ovsiienko
2019-11-04  1:01                   ` Wang, Haiyue
2019-11-02 18:31         ` Thomas Monjalon [this message]
2019-11-03  3:52     ` Wang, Haiyue
2019-11-03 22:20       ` Thomas Monjalon
2019-11-04  0:51         ` Wang, Haiyue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2431604.fJrMVA34KA@xps \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=chenmin.sun@intel.com \
    --cc=damarion@cisco.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=haiyue.wang@intel.com \
    --cc=jerinjacobk@gmail.com \
    --cc=ray.kinsella@intel.com \
    --cc=viacheslavo@mellanox.com \
    --cc=xiaolong.ye@intel.com \
    --cc=yu.y.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).