From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id CE2AD558A
 for <dev@dpdk.org>; Sun,  6 Nov 2016 22:09:10 +0100 (CET)
Received: by mail-wm0-f43.google.com with SMTP id f82so84527775wmf.1
 for <dev@dpdk.org>; Sun, 06 Nov 2016 13:09:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=2W0KYSFvgy5SfPby+t7mDHYjXW0ROtBYmH6tdubMNLw=;
 b=KYwyopeo9Tht9HA6+21IpOb371B59Dq2nRZqgZhkh+GRpwg3G34vr6QU7hPSsRnSaO
 IFgyh+RXwByRGTRLlX/8GSGcB2R1WPjpgVQhLaYTPy3sHcfSR186oFeJZuuFCLzW0iQM
 w+DIgOBLz0zqdgxv0QJnpbyoixnHH0ZdK5Dzmq5JsPNTLJbLPonQ8SBTgLkWEmpQ0fBB
 zSpnD+AI0KdlNAvz9z44LZOImUZPImYju/WPFigJ5kRDdTxzsdlaSoR/TCLv2FMjn2gt
 GLG6x5oIOSNuICJ6RJLm7E7Y90QLXQI/qkmENa7/mEzjbGhGq4OA2Lwar5UhE7qRVwGb
 wrQA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=2W0KYSFvgy5SfPby+t7mDHYjXW0ROtBYmH6tdubMNLw=;
 b=Ft33ybT2sCXATMIBlB2RD20NhidBUG7GklbgtkQiJZAiBUt3ZZViNWmOQHDrHLN12E
 DU/Z5U7BAW26CZ2EanGHp655VUYUefnzKQOdWRpIpp7SG0RgXEyfDZPRhc9swVFkaHcL
 8ypx4cCblm2QWm9q83ikMaAPb9QjuVfR1dq8wrCgYDau5SjryCsSgN9a70OeUSyiagxu
 5lwAkyGS/BpRkEOa72a1rXwvB59ARj9MT4qPGgSxJ/ooocstOgaC/2H0XPKbfiJ00+ui
 rNRDILsqLwSHV2hxU2G7BVlHJbwoarZCjEpJ7XaQZsk5MLa7hsLRY/GAy4BkOoMcvgf7
 /0Fw==
X-Gm-Message-State: ABUngvf68/85WAEqm1dNBXpN1YrtqTKLM8FsOhCO2lPLuSNai9/UhJ+CW979lUhpLxZ3Ic6H
X-Received: by 10.28.153.10 with SMTP id b10mr1032306wme.103.1478466550617;
 Sun, 06 Nov 2016 13:09:10 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id ia7sm26703553wjb.23.2016.11.06.13.09.09
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 06 Nov 2016 13:09:09 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org
Date: Sun, 06 Nov 2016 22:09:07 +0100
Message-ID: <2431986.cxPJYuksjQ@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <4122748.D2hJ4kS1ho@xps13>
References: <1475184293-18298-1-git-send-email-nikhil.rao@intel.com>
 <4122748.D2hJ4kS1ho@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal: fix bug in x86 cmpset
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Nov 2016 21:09:11 -0000

2016-09-29 18:34, Thomas Monjalon:
> 2016-09-30 02:54, Nikhil Rao:
> > The original code used movl instead of xchgl, this caused
> > rte_atomic64_cmpset to use ebx as the lower dword of the source
> > to cmpxchg8b instead of the lower dword of function argument "src".
> 
> Could you please start the explanation with a statement of
> what is wrong from an user point of view?
> It could help to understand how severe it is.

Please, we need a clear explanation of the bug, and an acknowledgement.