From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f175.google.com (mail-we0-f175.google.com
 [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id 151B168AE
 for <dev@dpdk.org>; Fri,  1 Aug 2014 16:48:16 +0200 (CEST)
Received: by mail-we0-f175.google.com with SMTP id t60so4427331wes.6
 for <dev@dpdk.org>; Fri, 01 Aug 2014 07:50:20 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=afwX9/v0vXKlmiSVqV/2xYvJfySUIhy7LNImGpDkIR0=;
 b=PgE5vuNh6bRaLr+8mxDKlqBpqjppf+u+KDom1vuXD5YAOYrPiZX6bA7GkyZ612vIvR
 xMfiwgZKHDtg7fhMfeVmMVqF2gcLXulhNip9otepUE/1+u4VfYMjy3CPKa1H8jbTYRTB
 cQRGshzSmT1ZEeVu/DRTUjggeA9oE3LMCt//HW2hxpSH5SEDXGW4/ORI6BIH31hoeAon
 xqg9pDZJt4sjqhFwOSuymqV7NhwSpfYQ2FYB7wjSKCNVxnM+G1w9/m53E3PWRP0DfYyp
 0IWScInP1xgS17KTDZLs3jMsq8iy/PS+vuNVioqlIZdSdu/9XzZV3ZN92a6qc3R9+b33
 2q/w==
X-Gm-Message-State: ALoCoQkv+CT4Uahmz61nYyny+dYnekrlgXFG+0/HtttA78wPIZOosbU+V2hTcKAaLJcqVMaxVRGU
X-Received: by 10.180.19.227 with SMTP id i3mr7520793wie.45.1406904619760;
 Fri, 01 Aug 2014 07:50:19 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id wd7sm21421305wjc.36.2014.08.01.07.50.18
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 01 Aug 2014 07:50:19 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 01 Aug 2014 16:50:06 +0200
Message-ID: <2434669.uPKS10IHqv@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.7-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <20140725105037.26769945@haswell.linuxnetplumber.net>
References: <20140725105037.26769945@haswell.linuxnetplumber.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH]  vmxnet3: initialize receive mode correctly
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Aug 2014 14:48:16 -0000

2014-07-25 10:50, Stephen Hemminger:
> The driver must listen to broadcast packets, like other devices.
> Otherwise protocols like ARP won't work!
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

> -	vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> +	vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);

It's also removing multicast at init. No comment so I assume everybody agrees.

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied for version 1.7.1.

Thanks
-- 
Thomas