* [dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly
@ 2014-07-25 17:50 Stephen Hemminger
2014-08-01 14:50 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2014-07-25 17:50 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
The driver must listen to broadcast packets, like other devices.
Otherwise protocols like ARP won't work!
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c 2014-07-25 10:49:18.720201127 -0700
+++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c 2014-07-25 10:49:18.720201127 -0700
@@ -522,7 +522,7 @@ vmxnet3_dev_start(struct rte_eth_dev *de
}
/* Setting proper Rx Mode and issue Rx Mode Update command */
- vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
+ vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
/*
* Don't need to handle events for now
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly
2014-07-25 17:50 [dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly Stephen Hemminger
@ 2014-08-01 14:50 ` Thomas Monjalon
2014-08-01 15:53 ` Stephen Hemminger
2014-08-26 0:33 ` Stephen Hemminger
0 siblings, 2 replies; 5+ messages in thread
From: Thomas Monjalon @ 2014-08-01 14:50 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
2014-07-25 10:50, Stephen Hemminger:
> The driver must listen to broadcast packets, like other devices.
> Otherwise protocols like ARP won't work!
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> - vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> + vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
It's also removing multicast at init. No comment so I assume everybody agrees.
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied for version 1.7.1.
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly
2014-08-01 14:50 ` Thomas Monjalon
@ 2014-08-01 15:53 ` Stephen Hemminger
2014-08-26 0:33 ` Stephen Hemminger
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2014-08-01 15:53 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Fri, 01 Aug 2014 16:50:06 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2014-07-25 10:50, Stephen Hemminger:
> > The driver must listen to broadcast packets, like other devices.
> > Otherwise protocols like ARP won't work!
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> > - vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> > + vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
>
> It's also removing multicast at init. No comment so I assume everybody agrees.
Just following what initial value for bare metal drivers is.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly
2014-08-01 14:50 ` Thomas Monjalon
2014-08-01 15:53 ` Stephen Hemminger
@ 2014-08-26 0:33 ` Stephen Hemminger
2014-08-26 6:50 ` Thomas Monjalon
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2014-08-26 0:33 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Fri, 01 Aug 2014 16:50:06 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2014-07-25 10:50, Stephen Hemminger:
> > The driver must listen to broadcast packets, like other devices.
> > Otherwise protocols like ARP won't work!
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> > - vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> > + vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
>
> It's also removing multicast at init. No comment so I assume everybody agrees.
>
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> Applied for version 1.7.1.
>
> Thanks
My general rule is to make all drivers behave the same.
In DPDK, the ixgbe driver is the "best known" reference.
In that driver "multicast promiscious" is disabled by default.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly
2014-08-26 0:33 ` Stephen Hemminger
@ 2014-08-26 6:50 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2014-08-26 6:50 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
2014-08-25 17:33, Stephen Hemminger:
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> > 2014-07-25 10:50, Stephen Hemminger:
> > > - vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> > > + vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
> >
> > It's also removing multicast at init. No comment so I assume everybody agrees.
>
> My general rule is to make all drivers behave the same.
I think it's a good rule :)
> In DPDK, the ixgbe driver is the "best known" reference.
> In that driver "multicast promiscious" is disabled by default.
OK, thanks.
--
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-26 6:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-25 17:50 [dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly Stephen Hemminger
2014-08-01 14:50 ` Thomas Monjalon
2014-08-01 15:53 ` Stephen Hemminger
2014-08-26 0:33 ` Stephen Hemminger
2014-08-26 6:50 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).