From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 559E7AE9A for ; Tue, 27 May 2014 10:57:23 +0200 (CEST) Received: by mail-wi0-f178.google.com with SMTP id cc10so1237000wib.5 for ; Tue, 27 May 2014 01:57:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=jLnE7thx6dRdvhJ4nHaP4SEsN32SCSzL53o1iH+vuK8=; b=NZJidngQldiFYU1Blgc3M76v+20vX9bBSihn38WdchM9w+InhEzLNqcqOYNQhlVBsU g5GOVwLBDPcDDwjWS+GNMLeRDqKMerrLnrKf0JByNLyMUkzJUwo4RcCfu/n96RXc1Fjk wRTUVabefNS6fC9+KHHnGIYFAVFjT1jugMQWYf7kp6rLfR954OncMlPZ+won1XqTnodG Tf56iMTn7ZVJJGZxxvhUYAyE38jvyYPXTMasXIYBORaVe/eCelgSnNvl+RkIhiofFYKD hPZMfzjsz8c49MRzSic4Aq/MsiUy9Di4UgWxz+sOGgwzPCbK1cN9Lk9OqF9lUSPsmXZm QLsA== X-Gm-Message-State: ALoCoQnTbbmeWofVcISS3kA9fDBfm1pADtJIxxvjUlYzbgl+RYahN13eA/lAVFHoMuAqE6eRlnGw X-Received: by 10.194.84.208 with SMTP id b16mr38628920wjz.55.1401181054160; Tue, 27 May 2014 01:57:34 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id lz11sm6652698wic.0.2014.05.27.01.57.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 May 2014 01:57:33 -0700 (PDT) From: Thomas Monjalon To: "Xu, HuilongX" Date: Tue, 27 May 2014 10:57:30 +0200 Message-ID: <2436275.7LybpPuKnj@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 04/16] Make igb_uio compilation optional X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 May 2014 08:57:23 -0000 Hi HuilongX, (sorry, my previous email was sent before I finished writing it) Thanks for testing patches. In order to be more efficient next times, I have few comments. 2014-05-27 02:43, Xu, HuilongX: > Currently, igb_uio is always compiled. Some Linux distribution may > not want to include igb_uio by default, so we need to make sure that > igb_uio compilation can be optional. 1) When replying to an email, there should be "> " in front of lines you have not written. Here, it's not easy to see what you are replying. > Signed-off-by: Anatoly Burakov > > 2) Your mailer is breaking the Signed-off line. > Test-by: HuilongX Xu > 3) If you do some tests (other than compiling), you should explain what are the tests (command lines and environment). > Compile pass 4) No need to notify that compilation is working. It's implicit (and mandatory) when sending a patch. > >>Compile OS: FC20 x86_64 > >>Kernel version: 3.13.6-200 > >>GCC version: 4.8.2 > >>Server: Crownpass > > --- > config/defconfig_i686-default-linuxapp-gcc | 1 + > config/defconfig_i686-default-linuxapp-icc | 1 + > config/defconfig_x86_64-default-linuxapp-gcc | 1 + > config/defconfig_x86_64-default-linuxapp-icc | 1 + > lib/librte_eal/linuxapp/Makefile | 2 ++ > lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +- > 6 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/config/defconfig_i686-default-linuxapp-gcc > b/config/defconfig_i686-default-linuxapp-gcc index 14bd3d1..ea90f12 100644 > --- a/config/defconfig_i686-default-linuxapp-gcc > +++ b/config/defconfig_i686-default-linuxapp-gcc 5) Please do not copy all the patch if you have nothing specific to say about it. Thanks for your help -- Thomas