From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 11E5C2C09 for ; Mon, 21 Mar 2016 11:09:34 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id r129so43390351wmr.1 for ; Mon, 21 Mar 2016 03:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=H0LUcf8/bzQKysU1ObkLbJXGSIriF0fv1BhC/6q2/VY=; b=vBOD76SSrNUZQSHLflpexb7riHTDR5QcqsdUJGp2ijnNocwbeHR0DcSdXL1esnSwsV nG1zo8fTb5eszy7Fh44wXFMa8h9/nfk6Xm1KDydKXzYKEmh89+6CBJ8K1iSXHiv/+jM5 IL5C3hYqoXH+H1JiWYSol0IR9c/dY1MT9Y3nedJNj0iLfzQMnu5nqOsYvGCAnrdSOPzO IYsvSrQ2SCAbQJumYAdcsA6TsQjKtP1Q8z+35QdrmxDUVN6HufbtBQAbGPettM1db5qK +6XofKxoFMiEI3rb9H8scdPovJSE1QuSMdABfE1wcqwOdEsNrj+V3Jb6RUKuW1xkgESN b0fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=H0LUcf8/bzQKysU1ObkLbJXGSIriF0fv1BhC/6q2/VY=; b=c7jFdiNWqI2eK3qS6yMtOcd/ZPzdvIUk0en5kgv1V380gtPJVLxbgqcvrNNEI9lIde 6zgrVmFR4ZDnzEeqglzcaBInsLFskdenZ8HZzMKj0uot/ll0vmik6VN/Hq8uow/5f0Su BI9P5ooSsldlNz7Gx4AiN5yZ+oVNbWVdQdlO9Ax4/mmhqk6YdjHWFMtT7LKtNF1aopit rIpcGoWajd4pftCuu5+72EAt2Ay/7Z7XLkP5g99nX9BB/NK363bNiBLSvrWhRqAX2ikE 1MxCbiNywzbKU+Q39kIPkhTr4hIsh+xAyZkV97oboGyGmSXKALV2dSpNfjKfQoD6G5Ps jEUA== X-Gm-Message-State: AD7BkJJkiqM6mpVjAA76koXUSFtiNLRteThxOOkJRqOizAvIgUTysUOawf5uvUigg/qofjRw X-Received: by 10.194.176.129 with SMTP id ci1mr14281970wjc.166.1458554973932; Mon, 21 Mar 2016 03:09:33 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id lh1sm24498038wjb.20.2016.03.21.03.09.33 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Mar 2016 03:09:33 -0700 (PDT) From: Thomas Monjalon To: Qian Xu , Masaru OKI Cc: dev@dpdk.org, stephen@networkplumber.org Date: Mon, 21 Mar 2016 11:07:56 +0100 Message-ID: <2437286.FLD0q4sve1@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458550874-15709-1-git-send-email-qian.q.xu@intel.com> References: <1458550874-15709-1-git-send-email-qian.q.xu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix vmware e1000 input/output error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 10:09:34 -0000 2016-03-21 17:01, Qian Xu: > INTX is badly emulated in Vmware, INTX toggle check didn't work > with Vmware e1000 device. The patch is to fix the issue. Is it possible to detect a VMware e1000 device? > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > case RTE_INTR_MODE_LEGACY: > - if (pci_intx_mask_supported(dev)) { > - dev_dbg(&dev->dev, "using INTX"); > - udev->info.irq_flags = IRQF_SHARED; > - udev->info.irq = dev->irq; > - udev->mode = RTE_INTR_MODE_LEGACY; > - break; > - } > - dev_notice(&dev->dev, "PCI INTX mask not supported\n"); > + dev_dbg(&dev->dev, "using INTX"); > + udev->info.irq_flags = IRQF_SHARED; > + udev->info.irq = dev->irq; > + udev->mode = RTE_INTR_MODE_LEGACY; > + break; > /* fall back to no IRQ */ > case RTE_INTR_MODE_NONE: This patch is removing the INTX support detection and the fallback to no IRQ.