From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id E26D69606
 for <dev@dpdk.org>; Thu, 19 May 2016 14:57:28 +0200 (CEST)
Received: by mail-wm0-f42.google.com with SMTP id a17so124897905wme.0
 for <dev@dpdk.org>; Thu, 19 May 2016 05:57:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=9La//MYX8dV5e5OgYSWFrraT8VaBik30GB7l+IzDo+A=;
 b=c4VXGcZkLNBN/49ISyRI8oRVoF1X1kBPVPwBA/LpyWSkxnxO1J4eVBJeiMKpvzPiE0
 yaqrNtLvTOPwARgH4io1OavvXqLoRLinajtevh0uIHk5X0/y/764sDRnb7UxQIQ1Ubks
 oUaaGBHKqU2w1jIq6k0cXY5hy0etn6tM0YfVoo/oi65Vkq/Y0/g5lAxQfwul3XyrgkFR
 3sD+A3OL9vHosfPU2VbMwaLflhBYOiizwRIpRjVqu6vfvxYfLUsh0BR3BJ2LxhxYhVwn
 nR3mLM6FDmwZEnmxeGkQC8mo5wDJpRM2vVWap9gXtjaj1hT3yzSAmW3bgS8SN99upsTK
 o4pg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=9La//MYX8dV5e5OgYSWFrraT8VaBik30GB7l+IzDo+A=;
 b=EKuGZ5MQNMngIl8R9pwbQtSjtreVFRu5kMyD8XN2qTnnJU+MZjrKHnxGERsDNvMZw4
 RC9zrSXwycBwwrL7ccvvCHpEpXPdys7CYvd6Qaw+8NmNZhIEvVQvc/1YzsGxtnVjbzPF
 J6e68m+w9XlCT14UB688EI89OItNGMq/xKt7duApu8RtUNvozgcpX14B3MvEsWYOfr0c
 HhAHCdWEYeN0BCk1JqXQYOYPTZfaNtmmfhiyzmC5hYZ71NBWn7s/UodA0lb1h1CFvOov
 nPw3HRzu5odyjOBhshl9WRefokxCjYTGcoDdkIBxxAQvBv1+ysuXrVjNDzO0F/68Wu6E
 jUCg==
X-Gm-Message-State: AOPr4FUJ29dD+xI+DtH7D9d4bEKFwi82Jxcr+3xHQc4DcAI2meE2TVbKVwlDAo4ApB3ZHx6W
X-Received: by 10.194.142.240 with SMTP id rz16mr13331939wjb.126.1463662648666; 
 Thu, 19 May 2016 05:57:28 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id g197sm35269569wme.15.2016.05.19.05.57.27
 (version=TLSv1/SSLv3 cipher=OTHER);
 Thu, 19 May 2016 05:57:28 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Yang, Ziye" <ziye.yang@intel.com>
Cc: dev@dpdk.org
Date: Thu, 19 May 2016 14:57:17 +0200
Message-ID: <243965117.o52RgkbZZP@xps13>
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <FA6C2217B01E9D48A581BB486602101401758FC6@shsmsx102.ccr.corp.intel.com>
References: <1462946895-49958-1-git-send-email-ziye.yang@intel.com>
 <1727235.C3RSOGSy8E@xps13>
 <FA6C2217B01E9D48A581BB486602101401758FC6@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] pci: Add the class_id support in pci probe
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 May 2016 12:57:29 -0000

2016-05-19 12:18, Yang, Ziye:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
> 2016-05-11 14:08, Ziye Yang:
> > +	dev->id.class_id = (uint32_t)tmp && CLASS_ANY_ID;
> 
> Should be a bitwise &. Why masking is needed?
> [Ziye]  Only 24bit info is needed.

What are the other bits?
Please put a comment in the code.