From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
 [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 6AC57C46E
 for <dev@dpdk.org>; Wed, 24 Jun 2015 22:50:34 +0200 (CEST)
Received: by wiwl6 with SMTP id l6so106031636wiw.0
 for <dev@dpdk.org>; Wed, 24 Jun 2015 13:50:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=YaezcM/V5cgVXJ2IU8ytwmff3ArJIm+aPBDf2BiVg20=;
 b=XOaxWD1zxbtXu6lRa2TS9KR8c/XoTzIM4y3iBX5Vi/hfLYjzShcItZQ2T8OKM3OH8r
 qF8dMn2/X+UYVMynPVWxCQ0B7OB6QgiabyoMNzl59oDPC6Uf4uBonvN2D0TR1fuHxgFk
 JIeSv7/Z4hB/Ec7odK3O1fBOssmo0uW/Dwnn+iTCjLZcFe2ly+NaSP4VdAzru3Jy4CZu
 5xwiMApHXmQi0fqm/PpXUBxbntryvJqUMJqtQBuv57THLgIjhyBsfHxHzS1uzydr3CQI
 hL/DyxwvuEn7Ladad7ryiFkilCsF723HhKlTql27g9ZH81gxYNtyD5+2pmSAJYXQSFVL
 XCIw==
X-Gm-Message-State: ALoCoQmNhT03LeCwoMW4bJxewFq08M4b+/7unzt+gMgODDYpJ8QaTOqEq6t+fP/WuiwihcM14dTg
X-Received: by 10.194.47.196 with SMTP id f4mr63069013wjn.46.1435179033045;
 Wed, 24 Jun 2015 13:50:33 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id s10sm42461092wjy.35.2015.06.24.13.50.31
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 24 Jun 2015 13:50:32 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 24 Jun 2015 22:49:26 +0200
Message-ID: <2441757.YP5B8U6YF3@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <20150624201537.GC31530@hmsreliant.think-freely.org>
References: <1435088014-18973-1-git-send-email-nhorman@tuxdriver.com>
 <2622142.skeap4pQmM@xps13>
 <20150624201537.GC31530@hmsreliant.think-freely.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCHv2 1/2] rte_compat.h : Clean up some typos
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jun 2015 20:50:34 -0000

2015-06-24 16:15, Neil Horman:
> On Wed, Jun 24, 2015 at 09:41:08PM +0200, Thomas Monjalon wrote:
> > 2015-06-24 14:34, Neil Horman:
> > > @@ -103,7 +103,7 @@
> > >  #define VERSION_SYMBOL(b, e, v)
> > 
> > Should be (b, e, n)
> > 
> > >  #define __vsym
> > >  #define BASE_SYMBOL(b, n)
> > 
> > Should be (b, e)
> > 
> > > -#define BIND_DEFAULT_SYMBOL(b, v)
> > > +#define BIND_DEFAULT_SYMBOL(b, e, n)
> > 
> > 
> > 
> Agreed, though thats really just cosmetic, given that the error is in the empty
> defines.  Can you fix it in patchwork by hand, or would you prefer a repost?

I can manage it but I think you'll need a repost for the patch 2/2 anyway.